From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWQdQ-0004rV-Fk for qemu-devel@nongnu.org; Mon, 31 Aug 2015 11:04:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWQdN-0005Ck-A4 for qemu-devel@nongnu.org; Mon, 31 Aug 2015 11:04:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWQdN-0005CK-1i for qemu-devel@nongnu.org; Mon, 31 Aug 2015 11:04:33 -0400 References: <1432776186-24515-1-git-send-email-changchun.ouyang@intel.com> <1439360742-2186-1-git-send-email-changchun.ouyang@intel.com> <1439360742-2186-2-git-send-email-changchun.ouyang@intel.com> <20150813121013-mutt-send-email-mst@redhat.com> <20150827154430-mutt-send-email-mst@redhat.com> <20150830091225-mutt-send-email-mst@redhat.com> <20150831142809-mutt-send-email-mst@redhat.com> From: Eric Blake Message-ID: <55E46CF9.2090304@redhat.com> Date: Mon, 31 Aug 2015 09:04:25 -0600 MIME-Version: 1.0 In-Reply-To: <20150831142809-mutt-send-email-mst@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K5dVSKxp5nHGBATs8XgRIFWbgtw3oeq56" Subject: Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , "Ouyang, Changchun" Cc: "snabb-devel@googlegroups.com" , "Liu, Yuanhan" , "thibaut.collet@6wind.com" , "qemu-devel@nongnu.org" , "n.nikolaev@virtualopensystems.com" , "luke@snabb.co" , "Long, Thomas" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K5dVSKxp5nHGBATs8XgRIFWbgtw3oeq56 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/31/2015 05:30 AM, Michael S. Tsirkin wrote: > On Mon, Aug 31, 2015 at 08:29:39AM +0000, Ouyang, Changchun wrote: >>>>>>> On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote:= >>>>>>>> Based on patch by Nikolay Nikolaev: When you start to have this much nested quoting,... >>>>>>>> -269,7 +270,7 @@ static void vhost_net_stop_one(struct >>>>>>>> vhost_net >>>>> *net, >>>>>>>> for (file.index =3D 0; file.index < net->dev.nvqs; ++fi= le.index) { >>>>>>>> const VhostOps *vhost_ops =3D net->dev.vhost_ops; >>>>>>>> int r =3D vhost_ops->vhost_call(&net->dev, >>> VHOST_RESET_OWNER, =2E..line wrapping of the quotes gets funky and starts mis-attributing portions of lines to the wrong quote level. >> Vhost backend can't support the queues number as much as the guest/qem= u requires, >> I think you mean we should let qemu exit in such a case, right? =20 >=20 > Exactly. And mis-attribution makes it that much harder to find the real content being added further down in the middle of 28k of mostly-quoted message. Please remember that it is okay to trim messages to the relevant portions, to make it easier for readers to quickly get at the new content= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K5dVSKxp5nHGBATs8XgRIFWbgtw3oeq56 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5Gz5AAoJEKeha0olJ0NqVSQH/3dq19QfBAkMY4x0Pr/LJRLf FfRwPDVHbXjrqF2t7NgzBawnsb0Z2VcZUV6fD40wG+3NUh7z+LObQL7I44JvpqZC PrG0sAyd7atFBl6fPycsXlSorCh+jUU+nYHPODt0MnF6BdDlJUdCOD8qnB7SQs5D +Sz88clm3hRTGZznKr3exPhp34zLSIJct5nXLFxV9n3oRQ9Ou/Q7mbxeigO1At6D fn8K9TSTj9VR4Uj3enNB2u15vzEvJyqUaZRzDWLxTy6GljMsolh2GcSkCnTwJTOo YjO+pM81UmsiHmlwh6zO4tQ9FOnwXGJ/Lnb/JeFWr6/y9FDeh60uygqlkBs8DX0= =mAmo -----END PGP SIGNATURE----- --K5dVSKxp5nHGBATs8XgRIFWbgtw3oeq56--