From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWRav-0004cb-0a for qemu-devel@nongnu.org; Mon, 31 Aug 2015 12:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWRaq-0002mY-SZ for qemu-devel@nongnu.org; Mon, 31 Aug 2015 12:06:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWRaq-0002lu-NM for qemu-devel@nongnu.org; Mon, 31 Aug 2015 12:06:00 -0400 References: <1440780366-7177-1-git-send-email-armbru@redhat.com> <1441036533-26113-1-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55E47B62.20207@redhat.com> Date: Mon, 31 Aug 2015 10:05:54 -0600 MIME-Version: 1.0 In-Reply-To: <1441036533-26113-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DlG1EA3pjBw1xXu3U5omxeCUEbR7MkE0G" Subject: Re: [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DlG1EA3pjBw1xXu3U5omxeCUEbR7MkE0G Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/31/2015 09:55 AM, Markus Armbruster wrote: > The first check ensures the second one can't trigger. Drop the first > one, because the second one is in a more logical place, and emits a > nicer error message. Second one added in 44bd1276; first one in older a8d4a2e4 (back before 'alternate' existed). I probably failed to delete the first one due to rebase churn on my end. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 8 -------- > tests/qapi-schema/union-base-no-discriminator.err | 2 +- > 2 files changed, 1 insertion(+), 9 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DlG1EA3pjBw1xXu3U5omxeCUEbR7MkE0G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5HtiAAoJEKeha0olJ0NqgB4IAKMnUtGnl8yFMCooN5baqUOO RxdDVHhvQ9CCfWgszkgrycW9LHXh0IBAz6i0peCOjJhufntgX0HpUoL1P2zglQY2 FMtmsqYLef/99/meDJFcAEuOcr3WeylVOpG+mC4jJrxUXBHX6RXXu+S++fmEVx/e rEbXrq3RbftXS25nb7/T/EAuvRtRpRSJWrwxhZYTG+1tUYKt+Pq7PCXN3Oqq3t3i 8xo7vsLKDLiV7KdEoYpC8WR0xfCmFWcOJzN+gY47ZCSctFblwpRQiP93VLwusLWU HS1162GEz9bdlrlTULI/MSX0yrJ5PUHzbp+/PP9nzAnCWwnvRIWx+ct/0ThPtJM= =DM9p -----END PGP SIGNATURE----- --DlG1EA3pjBw1xXu3U5omxeCUEbR7MkE0G--