From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWRiU-0007tI-2P for qemu-devel@nongnu.org; Mon, 31 Aug 2015 12:13:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWRiP-00074G-Uf for qemu-devel@nongnu.org; Mon, 31 Aug 2015 12:13:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWRiP-00073s-PC for qemu-devel@nongnu.org; Mon, 31 Aug 2015 12:13:49 -0400 References: <1441036533-26113-1-git-send-email-armbru@redhat.com> <1441036533-26113-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55E47D3B.6050103@redhat.com> Date: Mon, 31 Aug 2015 10:13:47 -0600 MIME-Version: 1.0 In-Reply-To: <1441036533-26113-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="25B7RBTjOjL84V58CocbcfvI60792Svc1" Subject: Re: [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --25B7RBTjOjL84V58CocbcfvI60792Svc1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/31/2015 09:55 AM, Markus Armbruster wrote: > We always report "should be a dictionary" then. This is misleading: > when allow_dict, it can be a dictionary or a type name string, else it > can only be a type name. This exposes the current (poor) conditions; then it will be obvious what improvements a later patch to fix it actually has. >=20 > Signed-off-by: Markus Armbruster > --- > tests/Makefile | 2 ++ > tests/qapi-schema/args-invalid.err | 1 + > tests/qapi-schema/args-invalid.exit | 1 + > tests/qapi-schema/args-invalid.json | 3 +++ > tests/qapi-schema/args-invalid.out | 0 > tests/qapi-schema/struct-data-invalid.err | 1 + > tests/qapi-schema/struct-data-invalid.exit | 1 + > tests/qapi-schema/struct-data-invalid.json | 3 +++ > tests/qapi-schema/struct-data-invalid.out | 0 > tests/qapi-schema/struct-member-invalid.err | 1 + > tests/qapi-schema/struct-member-invalid.exit | 1 + > tests/qapi-schema/struct-member-invalid.json | 3 +++ > tests/qapi-schema/struct-member-invalid.out | 0 > 13 files changed, 17 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --25B7RBTjOjL84V58CocbcfvI60792Svc1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5H07AAoJEKeha0olJ0Nq7nMH/RfpLWvDGDCRBbKCpmw7lr0U TklHqvy/Kg7o9Kh5N1Xujl5N7tfUZucBrzBpUyHbvDe4+m449PFM+maqbDnit86U EU3K7Bx+WcU2M87IsjAuFpn5E4Cya/K7ulXWm2d42Ajo1nayl9eKBG0McbV9tfkA gChPpjHasqk68Bsou7Bp3Xw5kzJ3FOaNv1CJHPCTUuKyHkXSD2m0dfz/qLUwKZ+a FKr43q2T8lKksREMfMt3lse7a/i3reqnqMI6uDsItl3TLmvADh43+4l6rbPRwtLp iwJsdT/dFx15AluGAfr2OGVqVmK4J/V/f2fRXm2bC2viIbe6iqOYPIqu7g3249I= =c7PB -----END PGP SIGNATURE----- --25B7RBTjOjL84V58CocbcfvI60792Svc1--