Re: [Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support

["Jason J. Herne" <jjherne@linux.vnet.ibm.com>]

On 08/31/2015 12:30 PM, Eric Blake wrote:
> On 08/31/2015 05:00 AM, Cornelia Huck wrote:
>> From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
>>
>> Add dump-skeys command to the human monitor.
>>
>> Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
>> Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>   hmp-commands.hx                 | 16 ++++++++++++++++
>>   hw/s390x/s390-skeys.c           | 12 ++++++++++++
>>   include/hw/s390x/storage-keys.h |  2 ++
>>   monitor.c                       |  4 ++++
>>   4 files changed, 34 insertions(+)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index d3b7932..803ff91 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -1053,6 +1053,22 @@ gdb. Without -z|-l|-s, the dump format is ELF.
>>               together with begin.
>>   ETEXI
>>
>> +#if defined(TARGET_S390X)
>> +    {
>> +        .name       = "dump-skeys",
>
> Most HMP commands use '_', not '-', for word separation.
>

I patterned my new command after dump-guest-memory since the functionality
was similar. Though it is easy enough to change if you would like.

-- 
-- Jason J. Herne (jjherne@linux.vnet.ibm.com)