From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWUHM-00076J-Pf for qemu-devel@nongnu.org; Mon, 31 Aug 2015 14:58:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWUHJ-0004pp-K5 for qemu-devel@nongnu.org; Mon, 31 Aug 2015 14:58:04 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:44631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWUHJ-0004ol-Fe for qemu-devel@nongnu.org; Mon, 31 Aug 2015 14:58:01 -0400 Received: from /spool/local by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 31 Aug 2015 14:58:00 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 5718DC90046 for ; Mon, 31 Aug 2015 14:48:57 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7VIvq9C54853632 for ; Mon, 31 Aug 2015 18:57:52 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7VIvqqF027495 for ; Mon, 31 Aug 2015 14:57:52 -0400 Message-ID: <55E4A3AF.500@linux.vnet.ibm.com> Date: Mon, 31 Aug 2015 14:57:51 -0400 From: "Jason J. Herne" MIME-Version: 1.0 References: <1441018834-8993-1-git-send-email-cornelia.huck@de.ibm.com> <1441018834-8993-6-git-send-email-cornelia.huck@de.ibm.com> <55E4813C.1050707@redhat.com> In-Reply-To: <55E4813C.1050707@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Cornelia Huck , qemu-devel@nongnu.org Cc: borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, agraf@suse.de On 08/31/2015 12:30 PM, Eric Blake wrote: > On 08/31/2015 05:00 AM, Cornelia Huck wrote: >> From: "Jason J. Herne" >> >> Add dump-skeys command to the human monitor. >> >> Reviewed-by: Thomas Huth >> Reviewed-by: David Hildenbrand >> Signed-off-by: Jason J. Herne >> Signed-off-by: Cornelia Huck >> --- >> hmp-commands.hx | 16 ++++++++++++++++ >> hw/s390x/s390-skeys.c | 12 ++++++++++++ >> include/hw/s390x/storage-keys.h | 2 ++ >> monitor.c | 4 ++++ >> 4 files changed, 34 insertions(+) >> >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index d3b7932..803ff91 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -1053,6 +1053,22 @@ gdb. Without -z|-l|-s, the dump format is ELF. >> together with begin. >> ETEXI >> >> +#if defined(TARGET_S390X) >> + { >> + .name = "dump-skeys", > > Most HMP commands use '_', not '-', for word separation. > I patterned my new command after dump-guest-memory since the functionality was similar. Though it is easy enough to change if you would like. -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)