From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 6/6] iotests: Test changed Quorum filename
Date: Mon, 31 Aug 2015 15:54:41 -0600 [thread overview]
Message-ID: <55E4CD21.7090302@redhat.com> (raw)
In-Reply-To: <1439939415-18180-7-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On 08/18/2015 05:10 PM, Max Reitz wrote:
> After drive-mirror replacing a Quorum child, the filename of the Quorum
> BDS should reflect the change. This patch replaces the existing test for
> whether the operation did actually exchange the BDS (which simply tested
> whether the new BDS existed) by a test which examines the children list
> contained in the Quorum BDS's filename as returned by query-block.
>
> As a nice side effect of confirming that the new BDS actually belongs to
> the Quorum BDS, this checks whether the filename was properly updated.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/041 | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-08-31 21:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 23:10 [Qemu-devel] [PATCH v4 0/6] block: Drop BDS.filename Max Reitz
2015-08-18 23:10 ` [Qemu-devel] [PATCH v4 1/6] block: Change bdrv_get_encrypted_filename() Max Reitz
2015-08-31 20:50 ` Eric Blake
2015-09-02 14:53 ` Max Reitz
2015-08-18 23:10 ` [Qemu-devel] [PATCH v4 2/6] block: Avoid BlockDriverState.filename Max Reitz
2015-08-31 20:53 ` Eric Blake
2015-08-18 23:10 ` [Qemu-devel] [PATCH v4 3/6] block: Add bdrv_filename() Max Reitz
2015-08-31 21:00 ` Eric Blake
2015-09-02 14:59 ` Max Reitz
2015-08-18 23:10 ` [Qemu-devel] [PATCH v4 4/6] qemu-img: Use bdrv_filename_alloc() for map Max Reitz
2015-08-31 21:23 ` Eric Blake
2015-08-18 23:10 ` [Qemu-devel] [PATCH v4 5/6] block: Drop BlockDriverState.filename Max Reitz
2015-08-31 21:50 ` Eric Blake
2015-08-18 23:10 ` [Qemu-devel] [PATCH v4 6/6] iotests: Test changed Quorum filename Max Reitz
2015-08-31 21:54 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E4CD21.7090302@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).