From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55790)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZWeFw-000367-7W
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:37:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZWeFt-0006on-2X
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:37:16 -0400
Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:35024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZWeFs-0006oh-RY
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:37:12 -0400
Received: by pacdd16 with SMTP id dd16so164053123pac.2
	for <qemu-devel@nongnu.org>; Mon, 31 Aug 2015 22:37:11 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1440433079-14458-1-git-send-email-rth@twiddle.net>
	<1440433079-14458-25-git-send-email-rth@twiddle.net>
	<CAFEAcA_DsxG_e5zz_VADvJYRmFhjRkdR5dNUtt5Y-rmeW1=+zg@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55E53984.5060001@twiddle.net>
Date: Mon, 31 Aug 2015 22:37:08 -0700
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_DsxG_e5zz_VADvJYRmFhjRkdR5dNUtt5Y-rmeW1=+zg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v14 24/33] target-tilegx: Handle shift
 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "walt@tilera.com" <walt@tilera.com>, Chris Metcalf <cmetcalf@ezchip.com>, QEMU Developers <qemu-devel@nongnu.org>, Chen Gang <xili_gchen_5257@hotmail.com>

On 08/30/2015 06:38 AM, Peter Maydell wrote:
> On 24 August 2015 at 17:17, Richard Henderson <rth@twiddle.net> wrote:
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>>   target-tilegx/translate.c | 57 +++++++++++++++++++++++++++++++++++++++++++++--
>>   1 file changed, 55 insertions(+), 2 deletions(-)
>>
>> diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
>> index 6be751b..4e6d577 100644
>> --- a/target-tilegx/translate.c
>> +++ b/target-tilegx/translate.c
>> @@ -474,6 +474,7 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
>>       TCGv tdest = dest_gr(dc, dest);
>>       TCGv tsrca = load_gr(dc, srca);
>>       TCGv tsrcb = load_gr(dc, srcb);
>> +    TCGv t0;
>
> Personally I would restrict the scope of this to just the
> case block where it's used.

It'll get used lots more by other insns in subsequent patches.  While 
restricting the scope is arguably ideal, it adds 3 lines for each use and 
brevity has its own appeal.

> Using shl for a shift right doesn't look right...
...
> Shift left used when shift right intended ?

Fixed.

>> @@ -1096,6 +1148,7 @@ static TileExcp gen_rri_opcode(DisasContext *dc, unsigned opext,
>>       case OE_SH(V2SHRSI, X1):
>>       case OE_SH(V2SHRUI, X0):
>>       case OE_SH(V2SHRUI, X1):
>> +        return TILEGX_EXCP_OPCODE_UNIMPLEMENTED;
>
> Why does this change appear in this patch?

I'm sure I meant to rebase it into the patch implementing ADDLI.

>
>>
>>       case OE(ADDLI_OPCODE_X0, 0, X0):
>>       case OE(ADDLI_OPCODE_X1, 0, X1):


r~