From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZWeKm-0004bW-LP
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:42:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZWeKh-0000h6-TV
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:42:16 -0400
Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:36453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZWeKh-0000h2-NH
	for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:42:11 -0400
Received: by pacgr6 with SMTP id gr6so13483478pac.3
	for <qemu-devel@nongnu.org>; Mon, 31 Aug 2015 22:42:11 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1440433079-14458-1-git-send-email-rth@twiddle.net>
	<1440433079-14458-27-git-send-email-rth@twiddle.net>
	<CAFEAcA-GXnSPK_ZH5anfUCHFAPyTnMR34O8Hm6M4AfhrqBgRwQ@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55E53AB0.3000809@twiddle.net>
Date: Mon, 31 Aug 2015 22:42:08 -0700
MIME-Version: 1.0
In-Reply-To: <CAFEAcA-GXnSPK_ZH5anfUCHFAPyTnMR34O8Hm6M4AfhrqBgRwQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v14 26/33] target-tilegx: Handle scalar
 multiply instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "walt@tilera.com" <walt@tilera.com>, Chris Metcalf <cmetcalf@ezchip.com>, QEMU Developers <qemu-devel@nongnu.org>, Chen Gang <xili_gchen_5257@hotmail.com>

On 08/30/2015 06:46 AM, Peter Maydell wrote:
> On 24 August 2015 at 17:17, Richard Henderson <rth@twiddle.net> wrote:
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>>   target-tilegx/translate.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 112 insertions(+)
>
> It seems a shame that these are all 32x32->64 multiplies
> (or in some cases 32x32->32), but we won't actually be able
> to make use of a host CPU 32x32->64 instruction.

Indeed.  For the most part I've been assuming a 64-bit host for all the ports 
I've been working on recently.  At which point it's not really worth doing all 
of the truncation and extension required to use such insns.


r~

>
> Still, these give the right results I think so
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM
>