From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWjC4-0005f7-Tp for qemu-devel@nongnu.org; Tue, 01 Sep 2015 06:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWjC1-0007X2-Nm for qemu-devel@nongnu.org; Tue, 01 Sep 2015 06:53:36 -0400 References: <1441046762-5788-1-git-send-email-thuth@redhat.com> <1441046762-5788-2-git-send-email-thuth@redhat.com> <20150901003808.GI11475@voom.redhat.com> From: Thomas Huth Message-ID: <55E583A6.4000600@redhat.com> Date: Tue, 1 Sep 2015 12:53:26 +0200 MIME-Version: 1.0 In-Reply-To: <20150901003808.GI11475@voom.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aqepUfje12iWUdxUvwaCS9G7IOVePWscl" Subject: Re: [Qemu-devel] [PATCH v2 1/2] spapr: Add support for hwrng when available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , michael@ellerman.id.au Cc: amit.shah@redhat.com, armbru@redhat.com, qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aqepUfje12iWUdxUvwaCS9G7IOVePWscl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/09/15 02:38, David Gibson wrote: > On Mon, Aug 31, 2015 at 08:46:01PM +0200, Thomas Huth wrote: >> From: Michael Ellerman >> >> Some powerpc systems have support for a hardware random number generat= or >> (hwrng). If such a hwrng is present the host kernel can provide access= >> to it via the H_RANDOM hcall. >> >> The kernel advertises the presence of a hwrng with the KVM_CAP_PPC_HWR= NG >> capability. If this is detected we add the appropriate device tree bit= s >> to advertise the presence of the hwrng to the guest kernel. >> >> Signed-off-by: Michael Ellerman >> [thuth: Refreshed patch so it applies to QEMU master branch] >> Signed-off-by: Thomas Huth >=20 > So, I'm confused by one thing. >=20 > I thought new kernel handled hcalls were supposed to be disabled by > default, but I don't see any calls to kvmppc_enable_hcall() to turn on > H_RANDOM. Michael's patch was from 2013, the kvmppc_enable_hcall() stuff seems to be from 2014 ... so the enablement is likely missing in this patch, indeed. I didn't test the in-kernel hypercall yet, just my QEMU implementation so far, that's why I did not notice this yet. Michael, do you want to rework your patch? Or shall I add an additional enablement patch to my queue? Thomas --aqepUfje12iWUdxUvwaCS9G7IOVePWscl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJV5YOmAAoJEC7Z13T+cC21XoAP/1puH2LxGNXCdP3fvq+0dzkk sOb3H+8FKFgX3EMKgKy605zIS4vd5j9ykSskFqGujFxLUMuAVJJxbM0gRRaofYO0 HUsTyNJaKlK3gK47HzzlSXvs8lmwRSjg4qJeZ78M6Z2MORhegPrV6ZrwyoEYJ3j+ i2R2xIdMxN9uMcL/bPXBgT5uy5pxPcnk4oqhaiqTqgMfGCJCnMaqDeDJ1LdON8Vn XuhUeLc+kkZigUIVL4Yapwr/MlRW0h0enWZOLcSwY33Bs9NJx3Z/NzZR7WYy+i7f M5JF178Iv3bLoLUlux7x5wgfhPlHezFSUcIzrsL62pmS7BhPXeuDNW4XhrRdiOKM xqp197SOfW3Nv6CnSs+XT7WQMEozU+l1b5eLEggp62KOgk+T3LDXKWBjT1LU2twE DnXFcMwhx8hdwUwDN3ELvnMY3fj0yPaFEe2UT20Q0tzy6v2RvU3mz1I8gOj9TluK tc/SzW34b5pyusNv9L6J8xFs5naDz3R2Wq4VjmyS0yrg/aABoxBs6iwm5V6sRXdE Z8DcObp0rGzs9EXWRGcIK6aXFdmbF9LhRBS54B1EOgFlWFEeUPPXnf9c6qW+6SYy xPFc5eaajGNLok8AxY/AXRvA1rUkc1nOp+8+yN7aHDSbHXzcW1L4LO4M4XTcCVZd 0VX1jK8JakbTskMWFvKx =zPUd -----END PGP SIGNATURE----- --aqepUfje12iWUdxUvwaCS9G7IOVePWscl--