From: Eric Blake <eblake@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>,
marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v4 13/13] qga: start a man page
Date: Tue, 1 Sep 2015 09:11:28 -0600 [thread overview]
Message-ID: <55E5C020.1050906@redhat.com> (raw)
In-Reply-To: <20150831232806.8622.81964@loki>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On 08/31/2015 05:28 PM, Michael Roth wrote:
>> Overall, fairly clean.
>
> Thanks for the review. Since these are grammatical fixes I've gone ahead and
> squashed these changes in, the only exception being suggestions regarding
> 'path' (the POSIX interpretation seems to make much more sense than associating
> it with an unrelated environment variable's semantics), and the ones that are
> outside the scope of this patch (short option args and 'help' as an alternative
> to '?').
>
> https://github.com/mdroth/qemu/commit/0e58c84d8618532bf6c3dcd3d13139fed5aaf3ca
>
> Sending a pull later this week, can add your Reviewed-by if it looks okay.
I've looked that over, and I'm okay if you want to amend and add:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-01 15:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 23:34 [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 01/13] qga: misc spelling marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 02/13] qga: use exit() when parsing options marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 03/13] qga: move string split in separate function marcandre.lureau
2015-08-27 9:18 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocated strings marcandre.lureau
2015-08-27 9:13 ` Denis V. Lunev
2015-08-27 9:17 ` Denis V. Lunev
2015-08-27 14:30 ` Marc-André Lureau
2015-08-27 16:15 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 05/13] qga: rename 'path' to 'channel_path' marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 06/13] qga: copy argument strings marcandre.lureau
2015-08-27 9:53 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 07/13] qga: move option parsing to separate function marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 08/13] qga: fill default options in main() marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 09/13] qga: move agent run in a separate function marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 10/13] qga: free a bit more marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 11/13] qga: add an optional qemu-ga.conf system configuration marcandre.lureau
2015-08-27 10:02 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 12/13] qga: add --dump-conf option marcandre.lureau
2015-08-26 23:38 ` Marc-André Lureau
2015-08-27 9:56 ` Denis V. Lunev
2015-08-27 9:57 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 13/13] qga: start a man page marcandre.lureau
2015-08-28 21:44 ` Eric Blake
2015-08-31 23:28 ` Michael Roth
2015-09-01 15:11 ` Eric Blake [this message]
2015-08-27 16:32 ` [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file Denis V. Lunev
2015-08-27 23:47 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5C020.1050906@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).