From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWnDh-0004EY-NG for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:11:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWnDd-0007Ms-U9 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:11:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWnDd-0007Mm-PB for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:11:29 -0400 References: <1440632099-5169-1-git-send-email-marcandre.lureau@redhat.com> <1440632099-5169-14-git-send-email-marcandre.lureau@redhat.com> <55E0D651.2090900@redhat.com> <20150831232806.8622.81964@loki> From: Eric Blake Message-ID: <55E5C020.1050906@redhat.com> Date: Tue, 1 Sep 2015 09:11:28 -0600 MIME-Version: 1.0 In-Reply-To: <20150831232806.8622.81964@loki> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aIO8AVMf2q4t9N5LvBmWgeK9fNfWKP5lf" Subject: Re: [Qemu-devel] [PATCH v4 13/13] qga: start a man page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: den@openvz.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aIO8AVMf2q4t9N5LvBmWgeK9fNfWKP5lf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/31/2015 05:28 PM, Michael Roth wrote: >> Overall, fairly clean. >=20 > Thanks for the review. Since these are grammatical fixes I've gone ahea= d and > squashed these changes in, the only exception being suggestions regardi= ng > 'path' (the POSIX interpretation seems to make much more sense than ass= ociating > it with an unrelated environment variable's semantics), and the ones th= at are > outside the scope of this patch (short option args and 'help' as an alt= ernative > to '?'). >=20 > https://github.com/mdroth/qemu/commit/0e58c84d8618532bf6c3dcd3d13139fed= 5aaf3ca >=20 > Sending a pull later this week, can add your Reviewed-by if it looks ok= ay. I've looked that over, and I'm okay if you want to amend and add: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aIO8AVMf2q4t9N5LvBmWgeK9fNfWKP5lf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5cAgAAoJEKeha0olJ0Nq0d4H/AxmtrfWazfLdiNDjmNozlvJ kjRyjYdwo+UA1Ki8uAsaJht+gJJhLSJavzkPHswLqzDIXkt/erYccsuf7i+h2W4l sFlyNhSSsPV0LlbmryegPjCBWYMJV/nlSVvzhFSlYe/0ZykhDMT65ZcfkqoqD8/I rObfnWghHwkx/2dvCtsdZDgdMWc9TQXderOpWSxVf+NCdyI33SSCW8w/cOpauYOu zYNyX6lmaIaUctZe4y1u2CdH3jNijSpkqmlF/yBXYihrAxLKFzY6bl75lSYaUpY7 3JXUwxdChDk3Vh9jePBKraLG5e1xzpEX5xo+0IR5/TAweaoSMAUkZ4mkpOHZzls= =b4l6 -----END PGP SIGNATURE----- --aIO8AVMf2q4t9N5LvBmWgeK9fNfWKP5lf--