From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWnZh-0001QQ-VB for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:34:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWnZh-0003TJ-1Z for qemu-devel@nongnu.org; Tue, 01 Sep 2015 11:34:17 -0400 References: <1439279489-13338-1-git-send-email-wency@cn.fujitsu.com> <1439279489-13338-6-git-send-email-wency@cn.fujitsu.com> <55E4A536.6040905@redhat.com> <55E4F767.1070602@cn.fujitsu.com> From: Eric Blake Message-ID: <55E5C572.7000606@redhat.com> Date: Tue, 1 Sep 2015 09:34:10 -0600 MIME-Version: 1.0 In-Reply-To: <55E4F767.1070602@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AHDOqJPeOUEuhUEBc02bHADLrMU4DkvBj" Subject: Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu devel , Markus Armbruster , Alberto Garcia , Stefan Hajnoczi Cc: Kevin Wolf , zhanghailiang , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , Gonglei , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AHDOqJPeOUEuhUEBc02bHADLrMU4DkvBj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/31/2015 06:55 PM, Wen Congyang wrote: >>> +This command is still a work in progress. It doesn't support all >>> +block drivers. Stay away from it unless you want it to help with >>> +its development. >> >> Maybe we should name it 'x-child-add' for now, so that we aren't bakin= g >> ourselves into a corner. >=20 > Do you mean the command name should be x-child-add? It is OK. Use of the 'x-' prefix means a command is experimental and may change or be withdrawn. It gives us a way to test if an interface is useful without committing to that interface long term. We've still got time before 2.5 to get blockdev-add working everywhere, in which case I think we are better off using blockdev-add to create a new unattached BDS and then have this command pass the node name to be made the new child, rather than all the options for opening the child from scratch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AHDOqJPeOUEuhUEBc02bHADLrMU4DkvBj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5cVzAAoJEKeha0olJ0Nq4oAH/2i2pptorl0kXlNdeS94gXTr k1vvRqqNy9YsUsy4utkWnHaIguli7kpxLKlB/Nkl9bgeo7erOc1kZF+1thqQpJWk NLADAnzMN57JnCp6AuFWUxUQ727H57yZQWpajJoFFxXzVJe1bwXOJSRMFu4koFdL stnrx1BIRURGVPipnVtFvKhMTF5aGByKRwyZePmf3kX9tGogN47jRXqxG8N8oYRt WXVPSdsWFm1/gFyVShCADiNG1ADOjDDiPnnE7PPubT4oLFX47lyqXxcq1fdvEcP6 rA8PBSAQaUAO9WtyiCVcv0PB/7BK0bKoIKyiYRcO8zEVIcLiNpE7HzFTM/OXioI= =7b8l -----END PGP SIGNATURE----- --AHDOqJPeOUEuhUEBc02bHADLrMU4DkvBj--