From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWo3n-0003Op-Ip for qemu-devel@nongnu.org; Tue, 01 Sep 2015 12:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWo3j-0007th-H2 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 12:05:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWo3j-0007tV-CX for qemu-devel@nongnu.org; Tue, 01 Sep 2015 12:05:19 -0400 References: <1441018834-8993-1-git-send-email-cornelia.huck@de.ibm.com> <1441018834-8993-6-git-send-email-cornelia.huck@de.ibm.com> <55E4813C.1050707@redhat.com> <55E4A3AF.500@linux.vnet.ibm.com> <20150901163010.229565fc.cornelia.huck@de.ibm.com> From: Eric Blake Message-ID: <55E5CCBD.2080102@redhat.com> Date: Tue, 1 Sep 2015 10:05:17 -0600 MIME-Version: 1.0 In-Reply-To: <20150901163010.229565fc.cornelia.huck@de.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F7rDjxvmuCSa14uhXE5BSoHoiGKVnrPvu" Subject: Re: [Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com, agraf@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F7rDjxvmuCSa14uhXE5BSoHoiGKVnrPvu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/01/2015 08:30 AM, Cornelia Huck wrote: >>>> +++ b/hmp-commands.hx >>>> @@ -1053,6 +1053,22 @@ gdb. Without -z|-l|-s, the dump format is ELF= =2E >>>> together with begin. >>>> ETEXI >>>> >>>> +#if defined(TARGET_S390X) >>>> + { >>>> + .name =3D "dump-skeys", >>> >>> Most HMP commands use '_', not '-', for word separation. >>> >> >> I patterned my new command after dump-guest-memory since the functiona= lity >> was similar. Though it is easy enough to change if you would like. >=20 > Eric, do you have a strong preference? I think either is fine; I can > either keep it as-is or merge in a change for the pull. HMP is not ABI; we can change it at will without worrying about back-compat issues. Consistency is nice, so I'd lean towards consistently using _ throughout HMP, but the preference is not strong enough so I don't object to keeping this commit as-is for the sake of merging, especially if dump-guest-memory also needs changing (that is, a followup patch that changes all HMP to be consistent in one go is not that much harder, even if this patch adds to the workload of that patch).= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --F7rDjxvmuCSa14uhXE5BSoHoiGKVnrPvu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5cy9AAoJEKeha0olJ0NqxHAH/29pnBeBOU3zdLgZGCANMqbs hRS/Y8Mk55NBqp/w+hO0O/5Wa1V0OGNe6HLjlUkMp78gixoPRV9/xYjvTpaqyCcd 5aqk/wNpz5zWftypqN7HLuO/AZckifq62tFWw0NKe+glQVC5AGxSEWKOEFNWs7CP tSrHCUMvXDZFnodMHsGSrN9wvRoT9w7JshagQZjn4S7jadDqZ999kK/HSmgjtv2l z4JjlQy6UZvICjjPY/dxhGp4GpDjLt/b7U14IWMqyUwd1GBUFgHwyNO1uPuLb6Ry +2XDIfcp3liNGZp1IdfHhTOfGpa7jKdQ2iSpuMtQMj2BBrFokG0XOuF0cvVvbbM= =9zco -----END PGP SIGNATURE----- --F7rDjxvmuCSa14uhXE5BSoHoiGKVnrPvu--