From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWrbW-0000BD-9U for qemu-devel@nongnu.org; Tue, 01 Sep 2015 15:52:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWrbS-0001py-LC for qemu-devel@nongnu.org; Tue, 01 Sep 2015 15:52:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWrbS-0001pb-Dg for qemu-devel@nongnu.org; Tue, 01 Sep 2015 15:52:22 -0400 References: <1440642804-29001-1-git-send-email-thuth@redhat.com> <1440642804-29001-5-git-send-email-thuth@redhat.com> From: Eric Blake Message-ID: <55E601F4.3020102@redhat.com> Date: Tue, 1 Sep 2015 13:52:20 -0600 MIME-Version: 1.0 In-Reply-To: <1440642804-29001-5-git-send-email-thuth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vcsfpb1VKVBlHwwROROH6Paps1Bsku9w8" Subject: Re: [Qemu-devel] [PATCH RFC 4/5] net/dump: Provide the dumping facility as a net filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Stefan Hajnoczi , Jason Wang , qemu-devel@nongnu.org, yanghy@cn.fujitsu.com Cc: Markus Armbruster , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vcsfpb1VKVBlHwwROROH6Paps1Bsku9w8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/26/2015 08:33 PM, Thomas Huth wrote: > Add glue code to use the dumping functions as a netdev > filter, too. >=20 > Signed-off-by: Thomas Huth > --- > net/dump.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++ > net/filter.c | 1 + > net/filters.h | 2 ++ > qapi-schema.json | 20 +++++++++++++++++++- > 4 files changed, 76 insertions(+), 1 deletion(-) >=20 > +++ b/net/filters.h > @@ -13,5 +13,7 @@ > =20 > int net_init_filter_buffer(const NetFilterOptions *opts, const char *n= ame, > int chain, NetClientState *netdev, Error **= errp); > +int net_init_filter_dump(const NetFilterOptions *opts, const char *nam= e, > + int chain, NetClientState *netdev, Error **= errp); Indentation is off. > =20 > #endif /* QEMU_NET_FILTERS_H */ > diff --git a/qapi-schema.json b/qapi-schema.json > index 7882641..71caca9 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2599,6 +2599,23 @@ > '*interval': 'uint32' } } > =20 > ## > +# @NetFilterDumpOptions > +# Otherwise, the interface looks clean. I can't tell from this patch whether the file is opened by qemu_open() (probably in net_dump_state_init() in an earlier patch of the series); but if not, you should fix that. That way, I can pass '/dev/fdset/XXX' as the name for an fd passed in by an earlier 'add-fd' even if qemu is restricted from open()ing files directly. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vcsfpb1VKVBlHwwROROH6Paps1Bsku9w8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5gH0AAoJEKeha0olJ0Nq33sH/1jsmAo4yHPXauJOVA1naBdo 2/kiQgN+cs3dWpOiTdbkElxrexKUPhzqbowPcUSlcxQESW9EBylCjGws/DfTt/OA ZdxOdhjJgTL+C0nDucVpEpqptg/sl/50fm7RbOiT7nlIc4OMwQZdxd0Pgf4reQ8I BnwTlfunPZm7stTNc1KzfqERf5wHPGl4d4VKKMdKdKsS+c7R0W5qNu2ud2TvvYz/ WQWo3pv3NU0kLiI+eHVTj64UdhRGGi7689Ve95YZUUVkYFQhBeMKUT3gPZzTT8Vp lPcTFrB/ImA1ZXsjM65XfGyjiPzU8M56TlFBaPGEOxhVv7ZfkgfjywRj4aVDoHA= =su3g -----END PGP SIGNATURE----- --vcsfpb1VKVBlHwwROROH6Paps1Bsku9w8--