From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWt53-0002GD-6I for qemu-devel@nongnu.org; Tue, 01 Sep 2015 17:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWt4y-0000Ke-77 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 17:27:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWt4x-0000KM-Vb for qemu-devel@nongnu.org; Tue, 01 Sep 2015 17:26:56 -0400 References: <1441118763-17510-1-git-send-email-jjherne@linux.vnet.ibm.com> <1441118763-17510-3-git-send-email-jjherne@linux.vnet.ibm.com> From: Eric Blake Message-ID: <55E6181D.3080709@redhat.com> Date: Tue, 1 Sep 2015 15:26:53 -0600 MIME-Version: 1.0 In-Reply-To: <1441118763-17510-3-git-send-email-jjherne@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KeWQGgeT3DvS39XcqC1P0kPf79jOa931p" Subject: Re: [Qemu-devel] [PATCH v5 2/5] migration: Parameters for auto-converge cpu throttling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" , afaerber@suse.de, amit.shah@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KeWQGgeT3DvS39XcqC1P0kPf79jOa931p Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/01/2015 08:46 AM, Jason J. Herne wrote: > Add migration parameters to allow the user to adjust the parameters > that control cpu throttling when auto-converge is in effect. The added > parameters are as follows: >=20 > x-cpu-throttle-initial : Initial percantage of time guest cpus are thro= ttled > when migration auto-converge is activated. >=20 > x-cpu-throttle-increment: throttle percantage increase each time > auto-converge detects that migration is not making progress. Marked experimental; do we think it will be promoted to stable before 2.5 is released? What happens if I set throttle-initial to 50 and throttle-increment to 50? The previous patch required throttle percentage to be between 1 and 99 inclusive; does that mean I cap out at 99 instead of an invalid throttle of 100? >=20 > Signed-off-by: Jason J. Herne > Reviewed-by: Dr. David Alan Gilbert > --- > hmp.c | 16 ++++++++++++++++ > migration/migration.c | 46 +++++++++++++++++++++++++++++++++++++++++++= ++- > qapi-schema.json | 33 ++++++++++++++++++++++++++++++--- > 3 files changed, 91 insertions(+), 4 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -587,10 +587,18 @@ > # compression, so set the decompress-threads to the number ab= out 1/4 > # of compress-threads is adequate. > # > +# @x-cpu-throttle-initial: Initial percentage of time guest cpus are t= hrottled > +# when migration auto-converge is activated. > +# (Since 2.4) > +# > +# @x-cpu-throttle-increment: throttle percentage increase each time > +# auto-converge detects that migration is n= ot making > +# progress. (Since 2.4) We've missed 2.4; these lines need to say (Since 2.5). > # Since: 2.4 > ## > { 'enum': 'MigrationParameter', > - 'data': ['compress-level', 'compress-threads', 'decompress-threads']= } > + 'data': ['compress-level', 'compress-threads', 'decompress-threads',= > + 'x-cpu-throttle-initial', 'x-cpu-throttle-increment'] } > =20 > # > # @migrate-set-parameters > @@ -603,12 +611,22 @@ > # > # @decompress-threads: decompression thread count > # > +# @x-cpu-throttle-initial: Initial percentage of time guest cpus are t= hrottled > +# when migration auto-converge is activated. > +# (Since 2.4) Would be nice to document the default (20). > +# > +# @x-cpu-throttle-increment: throttle percentage increase each time > +# auto-converge detects that migration is n= ot making > +# progress. (Since 2.4) And again (10). Also, same comment about needing 2.5. > @@ -618,13 +636,22 @@ > # @compress-threads: compression thread count > # > # @decompress-threads: decompression thread count > +# @x-cpu-throttle-initial: Initial percentage of time guest cpus are t= hrottled > +# when migration auto-converge is activated. > +# (Since 2.4) > +# > +# @x-cpu-throttle-increment: throttle percentage increase each time > +# auto-converge detects that migration is n= ot making > +# progress. (Since 2.4) 2.5. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KeWQGgeT3DvS39XcqC1P0kPf79jOa931p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5hgdAAoJEKeha0olJ0Nq5OwIAIVtEcngKWOMu8PBIoeogvFi LSsMYwKpR15005FiX9jd1rjokIy8OnbwRiomvDAVStOlzbAgFRkH4TaURuVnGGOI XhtMTsbCxbo1wLh1nJsHwAJUfqzfxPCOb5ebPBDltPWZTArpGaRa4iPqT/tZ+20k AEobN76t9olVW5wNg61D2eJSlbtFuQsK5G2xtFoRt1ecS5ItZoR8aiQogrqCHrKF LEFs2X1VZqkEb6uadySvCWFDX76lmWuWrNUaBYtp5v5IaVRlBcjEfEPSzI32QevM QwG+mNXQLwChYVNv0eaLbSQiEgA5fXgcqktkX7hnrGP7dzBXfd1DvvtrjWk9CRU= =5/VB -----END PGP SIGNATURE----- --KeWQGgeT3DvS39XcqC1P0kPf79jOa931p--