From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWtwt-0001Wk-Nz for qemu-devel@nongnu.org; Tue, 01 Sep 2015 18:22:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWtwq-0007fw-K4 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 18:22:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWtwq-0007fs-C1 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 18:22:36 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id CEE758E3DE for ; Tue, 1 Sep 2015 22:22:35 +0000 (UTC) References: <1440793108-25061-1-git-send-email-lersek@redhat.com> <55E600C5.9030505@redhat.com> <55E62138.1010209@redhat.com> From: Eric Blake Message-ID: <55E6251F.8020500@redhat.com> Date: Tue, 1 Sep 2015 16:22:23 -0600 MIME-Version: 1.0 In-Reply-To: <55E62138.1010209@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DmuWKCxN8NiSLR3AoOXn6BWSl1Amfwtcd" Subject: Re: [Qemu-devel] [RFC] docs: describe QEMU's VMGenID design List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org Cc: Gal Hammer , Paolo Bonzini , Igor Mammedov , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DmuWKCxN8NiSLR3AoOXn6BWSl1Amfwtcd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/01/2015 04:05 PM, Laszlo Ersek wrote: >=20 > (3) I couldn't decide if this text file should go under docs/, or > docs/specs. The tricky fact about this specific vmgenid design is that > the guest will "know" about it, but no *specific* guest code needs to b= e > written for it. >=20 > First, the ACPI linker/loader clients in both SeaBIOS and OVMF should > "just work" (without any changes). In that sense the *specific* design > here is not guest ABI. The ACPI linker/loader is guest ABI instead; thi= s > design is just a "clever" application of the ACPI linker/loader. (I can= > call it clever, it's only in part my idea. :)) >=20 > Second, guest operating systems will need drivers for this device > (obviously), but those drivers are ACPI based, and will have to consult= > the Microsoft spec only, not this file. >=20 > Given the above two (ie. neither guest firmare developers nor guest OS > developers need read this text file), I'd say this is not guest ABI. It= > is (detailed) documentation / specification for some QEMU internals. >=20 > Do you think the file should go under docs/, not docs/specs? I don't know if there is a strong explanation for why we have the separation, but given your argument, docs/ (all qemu-related documentation that has no more specific location) indeed sounds slightly better than docs/specs/ (files that independent implementations must pay attention to). >>> +migration. Quoting the spec, >> >>> + The virtual machine generation ID is a feature whereby the virtu= al machines >> >> s/machines/machine's/ [oh wait, you're quoting Microsoft's poor gramma= r] >=20 > Yep :) I noticed that. I resisted the urge to fix it. :) A pedantic editor might write "machines [sic] BIOS", but that just calls attention to the blunder with an intent to appear snobbish. You could possibly get away with "whereby the virtual [machine's] BIOS" to make the sentence grammatically correct while still marking your deviations from the original, and without calling as much attention to the mistake, but even that feels overboard. So I agree with your decision to leave it alone (we've already called enough attention to it in this thread without needing any further time spent on it). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DmuWKCxN8NiSLR3AoOXn6BWSl1Amfwtcd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5iUgAAoJEKeha0olJ0NqcckH/iyf4a99ZLa1R2gbkvJ6Q1FB P18y/wDNXVIzY1dJ2kX+IbnQVULIry/mVDTl4t5BzHfpW3XZD46XfOS08VaDSxUm XjFav6Xvu7Ui3g6/jyIMpDXkQjdjoqLldxdiMbr4lbKQbf1/qwRAFlbaxaMzxhj+ 8QDFlfmmk0wXzcdbTfq8pwRE3pM/V+C+NzJhPy0ESZkLboWSC61eDiUcifNw2uuZ ONsNRdK8QXXOOsU96ynd1JdAh7bEFlrNyyG4Qu7imreDcW29/J0eGs8nH7W80SoR Z+bqiPnEd89fPUwVMsK7ZnRTBauEDCiDzblWuLWemazcQ7gTwb28XXzVjMHw3XE= =NsA4 -----END PGP SIGNATURE----- --DmuWKCxN8NiSLR3AoOXn6BWSl1Amfwtcd--