From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX4cT-0005Cn-SM for qemu-devel@nongnu.org; Wed, 02 Sep 2015 05:46:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX4cO-0005Xb-Q7 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 05:46:17 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:39845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX4cO-00051T-Gs for qemu-devel@nongnu.org; Wed, 02 Sep 2015 05:46:12 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Sep 2015 10:45:14 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id DB43817D9229 for ; Wed, 2 Sep 2015 10:15:05 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t829DNpx30212148 for ; Wed, 2 Sep 2015 09:13:23 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t829DN9D000840 for ; Wed, 2 Sep 2015 03:13:23 -0600 Message-ID: <55E6BDB2.1050109@de.ibm.com> Date: Wed, 02 Sep 2015 11:13:22 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <559CE901.1040702@linux.vnet.ibm.com> <20150708112848.343434ad@bee> <20150708130320.7cde018f@bee> <55A62C9E.4080600@linux.vnet.ibm.com> <55C0C327.3030109@linux.vnet.ibm.com> <55C1BF9A.5040407@linux.vnet.ibm.com> <55C40FEF.8090407@linux.vnet.ibm.com> <55C84F82.9030009@linux.vnet.ibm.com> <89F73019-153F-4692-B0C1-4D4C187C5E85@suse.de> <55CC4CCB.3080002@linux.vnet.ibm.com> <55D58DBA.1020500@linux.vnet.ibm.com> <55D5EACC.3050105@suse.de> In-Reply-To: <55D5EACC.3050105@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [kvm-s390] qemu-system-s390x: cannot use stdio by multiple character devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , tu bo Cc: "dahi@linux.vnet.ibm.com" , jfrei@linux.vnet.ibm.com, jno@linux.vnet.ibm.com, Michael Mueller , qemu-devel@nongnu.org Am 20.08.2015 um 16:57 schrieb Alexander Graf: > > > On 20.08.15 01:20, tu bo wrote: >> Hi Alex: >> >> Ping you again just in case you did not get my mail :-) >> >> On 08/13/2015 03:52 PM, tu bo wrote: >>> Hi Alex: >>> >>> I added one disk device for test case 068(qemu/tests/qemu-iotests/068, >>> which is for for loading a saved VM state from a qcow2 image ), >>> and got the same problem for s390-virtio-ccw. Below is my steps: >>> 1. qemu-img create -f qcow2 scratch/t.qcow2 64M >>> 2. [root@r17lp42 qemu-iotests]# ../../s390x-softmmu/qemu-system-s390x >>> -nodefaults -nographic -monitor stdio -serial none -hda scratch/t.qcow2 >>> QEMU 2.3.94 monitor - type 'help' for more information >>> (qemu) [root@r17lp42 qemu-iotests]# >>> >>> For s390-virtio, test result is as expected >>> 1. qemu-img create -f qcow2 scratch/t.qcow2 64M >>> 2. [root@r17lp42 qemu-iotests]# qemu-system-s390x -nodefaults >>> -nographic -monitor stdio -serial none -hda scratch/t.qcow2 >>> QEMU 2.3.50 monitor - type 'help' for more information >>> (qemu) info roms >>> addr=0000000000009000 size=0x000ce8 mem=ram >>> name="/usr/share/qemu/s390-zipl.rom" >>> (qemu) savevm 0 >>> (qemu) >>> (qemu) quit >>> 3.[root@r17lp42 qemu-iotests]# qemu-system-s390x -nodefaults >>> -nographic -monitor stdio -serial none -hda scratch/t.qcow2 -loadvm 0 >>> QEMU 2.3.50 monitor - type 'help' for more information >>> (qemu) >>> >>> For x86-64, test result is as expected, >>> 1. [gavin@oc6333346435 qemu-iotests]$ qemu-img create -f qcow2 >>> scratch/t.qcow2 64M >>> 2. [gavin@oc6333346435 qemu-iotests]$ >>> ../../x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic >>> -monitor stdio -serial none -hda scratch/t.qcow2 >>> QEMU 2.3.94 monitor - type 'help' for more information >>> (qemu) info roms >>> fw=genroms/kvmvapic.bin size=0x002400 name="kvmvapic.bin" >>> addr=00000000fffc0000 size=0x040000 mem=rom name="bios-256k.bin" >>> /rom@etc/acpi/tables size=0x200000 name="etc/acpi/tables" >>> /rom@etc/table-loader size=0x001000 name="etc/table-loader" >>> /rom@etc/acpi/rsdp size=0x000024 name="etc/acpi/rsdp" >>> (qemu) savevm 0 >>> (qemu) >>> 3. [gavin@oc6333346435 qemu-iotests]$ >>> ../../x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic >>> -monitor stdio -serial none -hda scratch/t.qcow2 -loadvm 0 >>> QEMU 2.3.94 monitor - type 'help' for more information >>> (qemu) >>> >>> Could you share me why s390-virtio-ccw has different behavior with >>> s390-virtio & x86_64 for this scenario? thanks > > Because the s390 folks at IBM thought it'd be cool to emit a panic > (read: shut down) in the ccw bootloader when there is a problem? ;) Which is the right thing to do on an s390. On fatal errors, disabled wait is used in all operating systems. > > If this breaks test cases for you, please coordinate with Christian > Borntraeger and Eugene Dvurechenski whether it makes sense to change it. -no-shutdown might help, e.g. something like this diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068 index b72e555..2185477 100755 --- a/tests/qemu-iotests/068 +++ b/tests/qemu-iotests/068 @@ -52,11 +52,11 @@ echo _make_test_img $IMG_SIZE # Give qemu some time to boot before saving the VM state bash -c 'sleep 1; echo -e "savevm 0\nquit"' |\ - $QEMU -nographic -monitor stdio -serial none -hda "$TEST_IMG" |\ + $QEMU -no-shutdown -nographic -nodefaults -monitor stdio -serial none -hda "$TEST_IMG" |\ _filter_qemu # Now try to continue from that VM state (this should just work) echo quit |\ - $QEMU -nographic -monitor stdio -serial none -hda "$TEST_IMG" -loadvm 0 |\ + $QEMU -no-shutdown -nographic -nodefaults -monitor stdio -serial none -hda "$TEST_IMG" -loadvm 0 |\ _filter_qemu # success, all done