From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX4Wk-0000Tk-AA for qemu-devel@nongnu.org; Wed, 02 Sep 2015 05:40:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX4Wh-0002MJ-4D for qemu-devel@nongnu.org; Wed, 02 Sep 2015 05:40:22 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:33213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX4Wg-0002Ls-RF for qemu-devel@nongnu.org; Wed, 02 Sep 2015 05:40:19 -0400 Received: by wicmc4 with SMTP id mc4so59640309wic.0 for ; Wed, 02 Sep 2015 02:40:18 -0700 (PDT) Sender: Paolo Bonzini References: <1441101059-14269-1-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <55E6C407.6030708@redhat.com> Date: Wed, 2 Sep 2015 11:40:23 +0200 MIME-Version: 1.0 In-Reply-To: <1441101059-14269-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Programmingkid , Gonglei , Markus Armbruster , =?UTF-8?Q?Andreas_F=c3=a4rber?= On 01/09/2015 11:50, Daniel P. Berrange wrote: > Similarly objects are required to implement the > user-creatable interface > > (qemu) object_del /machine/unattached/device[4] > /machine/unattached/device[4] is not a user-creatable object The question is not whether it's user-creatable, but whether it's user-created. It would probably be bad to delete the iothread that x-data-plane=on creates. IIRC the id is mandatory for all of object_add (HMP), object-add (QMP) and -object, so I would do without the change to object_del. Paolo