From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX5Xx-0005A7-U5 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 06:45:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX5Xt-0005XX-Bg for qemu-devel@nongnu.org; Wed, 02 Sep 2015 06:45:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:23877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX5Xt-0005Wy-4h for qemu-devel@nongnu.org; Wed, 02 Sep 2015 06:45:37 -0400 References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-5-git-send-email-guangrong.xiao@linux.intel.com> <20150902121852.584bc410@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: <55E6D1E6.6070001@linux.intel.com> Date: Wed, 2 Sep 2015 18:39:34 +0800 MIME-Version: 1.0 In-Reply-To: <20150902121852.584bc410@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 04/18] acpi: add aml_sizeof List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, rth@twiddle.net On 09/02/2015 06:18 PM, Igor Mammedov wrote: > On Fri, 14 Aug 2015 22:51:57 +0800 > Xiao Guangrong wrote: > >> Implement SizeOf term which is used by NVDIMM _DSM method in later patch >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/aml-build.c | 8 ++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 9 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 9e89efc..a526eed 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1143,6 +1143,14 @@ Aml *aml_derefof(Aml *arg) >> return var; >> } >> >> +/* ACPI 6.0: 20.2.5.4 Type 2 Opcodes Encoding: DefSizeOf */ > ditto, refer to to the first revision where it's appeared > Good to me, will do. :)