Re: [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

On 09/02/2015 08:23 AM, Alberto Garcia wrote:
> On Tue 01 Sep 2015 04:40:02 PM CEST, Kevin Wolf wrote:
> 
>>>> Let's avoid such magic and instead add a new, clean blockdev-*
>>>> style command. Maybe call it simply blockdev-snapshot; the -sync
>>>> part was added because we knew it wouldn't be the final version of
>>>> the command.  Now we don't have any bdrv_open() in it any more that
>>>> could by synchronous or asynchronous.
> 
> Ok, I have a first working prototype of the new command using
> references as suggested.
> 
>> { 'struct': 'BlockdevSnapshot',
>>   'data': { '*device': 'str', '*node-name': 'str',
>>             'snapshot-file': 'str', '*snapshot-node-name': 'str',
>>             '*format': 'str', '*mode': 'NewImageMode' } }
>   [...]
>>
>> What you really need for the version with a reference is just:
>>
>> { 'struct': 'BlockdevSnapshot',
>>   'data': { 'device': 'str', 'snapshot': 'str' } }
> 
> And what do I do with the old BlockdevSnapshot? I guess it can just be
> renamed to BlockdevSnapshotSync or something like that?

Sure. And one of the nice things with the ongoing introspection work is
that qapi type names are NOT exposed as ABI (changing the name of a type
affects the generated C code, but does not affect what a QMP client
sends over the wire), so it is safe to do.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]