From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXAC9-0005gN-L6 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 11:43:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXAC8-00034f-JQ for qemu-devel@nongnu.org; Wed, 02 Sep 2015 11:43:29 -0400 References: <457103c2204e849aea3b83ffd78fad049d8d923d.1441014844.git.berto@igalia.com> <55E4B0CC.6070906@redhat.com> <55E4B374.70800@redhat.com> <20150901113111.GB4304@noname.redhat.com> <20150901144002.GF4304@noname.redhat.com> From: Eric Blake Message-ID: <55E71918.4000300@redhat.com> Date: Wed, 2 Sep 2015 09:43:20 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q0nL6iwuQmHvKRt4f65rmlg6sDfaWlhgx" Subject: Re: [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q0nL6iwuQmHvKRt4f65rmlg6sDfaWlhgx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/02/2015 08:23 AM, Alberto Garcia wrote: > On Tue 01 Sep 2015 04:40:02 PM CEST, Kevin Wolf wrote: >=20 >>>> Let's avoid such magic and instead add a new, clean blockdev-* >>>> style command. Maybe call it simply blockdev-snapshot; the -sync >>>> part was added because we knew it wouldn't be the final version of >>>> the command. Now we don't have any bdrv_open() in it any more that >>>> could by synchronous or asynchronous. >=20 > Ok, I have a first working prototype of the new command using > references as suggested. >=20 >> { 'struct': 'BlockdevSnapshot', >> 'data': { '*device': 'str', '*node-name': 'str', >> 'snapshot-file': 'str', '*snapshot-node-name': 'str', >> '*format': 'str', '*mode': 'NewImageMode' } } > [...] >> >> What you really need for the version with a reference is just: >> >> { 'struct': 'BlockdevSnapshot', >> 'data': { 'device': 'str', 'snapshot': 'str' } } >=20 > And what do I do with the old BlockdevSnapshot? I guess it can just be > renamed to BlockdevSnapshotSync or something like that? Sure. And one of the nice things with the ongoing introspection work is that qapi type names are NOT exposed as ABI (changing the name of a type affects the generated C code, but does not affect what a QMP client sends over the wire), so it is safe to do. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Q0nL6iwuQmHvKRt4f65rmlg6sDfaWlhgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5xkYAAoJEKeha0olJ0NqAusH/2eBuIetQSay0ejwIglKF7On AH+TnOIX+C6wn7QQLMiA5rKdttkOwsC8z1ul1YXvU5Qzr1XT0f/4dAutO/m1Mjdk CdhUaJZggm+MYW0Pgmehmcu3l+8hwPWv1DdsEqDfkT7oAjVCY1sCXjh+8WvuPrPV k1agKU+77CHMxPGASI9+QHFZzUYQQnw6l84ZMOeznSiq+oqzXoZz+wHHSIhd6w7U 0qvgxIF4MpvFcNIE8owhwEKANJvNrtZG9V6Yyn5PhrS9WvMDZ2kOXPCYRDdop6dM y75ToRc6/8CbZUC96H92irWCij6XlrV1MK1QrLKfbiyCHQMFykbw1Dfai0tLw00= =TGN2 -----END PGP SIGNATURE----- --Q0nL6iwuQmHvKRt4f65rmlg6sDfaWlhgx--