From: Eric Blake <eblake@redhat.com>
To: Pierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, gkurz@linux.vnet.ibm.com,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/2] virtio dataplane: adapt dataplane for virtio Version 1
Date: Wed, 2 Sep 2015 09:59:37 -0600 [thread overview]
Message-ID: <55E71CE9.5090303@redhat.com> (raw)
In-Reply-To: <1441206756-21918-1-git-send-email-pmorel@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
[meta-comment]
On 09/02/2015 09:12 AM, Pierre Morel wrote:
> Let dataplane allocate different region for the desc/avail/used
> ring regions.
> Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail
> rings accordingly.
This part is fine.
>
> Changes from V2:
> - incorporate the code directly in vring_setup().
> - added room for the event indexes used with VIRTIO_RING_F_EVENT_IDX
>
> Changes from v1:
> - use a macro to gain LOCs inside of vring_setup()
But the above changelog text belongs better...
>
> Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
> ---
...here after the '---' separator, where it will be stripped by 'git
am'. It is useful for reviewers of the earlier versions, but in the
long run, when reading 'git log', we will only care about what got
committed, not how many tries it took to get to that point.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-02 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 15:12 [Qemu-devel] [PATCH v3 1/2] virtio dataplane: adapt dataplane for virtio Version 1 Pierre Morel
2015-09-02 15:59 ` Eric Blake [this message]
2015-09-02 16:37 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E71CE9.5090303@redhat.com \
--to=eblake@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).