From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXAyg-0003AJ-Ek for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:33:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXAyf-0000Cq-84 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:33:38 -0400 References: <1441183880-26993-1-git-send-email-wency@cn.fujitsu.com> <1441183880-26993-12-git-send-email-wency@cn.fujitsu.com> From: Eric Blake Message-ID: <55E724D4.4000202@redhat.com> Date: Wed, 2 Sep 2015 10:33:24 -0600 MIME-Version: 1.0 In-Reply-To: <1441183880-26993-12-git-send-email-wency@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M0pppTO7U6Cdw0GMq7GCTUghonxTOrir5" Subject: Re: [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu devel , Fam Zheng , Max Reitz , Paolo Bonzini , Stefan Hajnoczi Cc: Kevin Wolf , Michael Roth , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , "Michael R. Hines" , Luiz Capitulino , Gonglei , Yang Hongyang , zhanghailiang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M0pppTO7U6Cdw0GMq7GCTUghonxTOrir5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/02/2015 02:51 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Luiz Capitulino > Cc: Michael Roth > Reviewed-by: Paolo Bonzini > --- > block.c | 43 +++++++++++++++++++++++++++++++++++++++= ++++ > include/block/block.h | 5 +++++ > include/block/block_int.h | 14 ++++++++++++++ > qapi/block-core.json | 15 +++++++++++++++ > 4 files changed, 77 insertions(+) >=20 Just an interface review for now: > +++ b/qapi/block-core.json > @@ -1810,6 +1810,21 @@ > 'data': { '*export': 'str' } } > =20 > ## > +# @ReplicationMode > +# > +# An enumeration of replication modes. > +# > +# @unprotected: Replication is not started or after failover. Maybe: Replication is either not started, or has experienced failover. > +# > +# @primary: Primary mode, the vm's state will be sent to secondary QEM= U. > +# > +# @secondary: Secondary mode, receive the vm's state from primary QEMU= =2E > +# > +# Since: 2.4 You've missed 2.4; this should be 2.5. > +## > +{ 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] } Where is 'unprotected' in this list? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M0pppTO7U6Cdw0GMq7GCTUghonxTOrir5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5yTUAAoJEKeha0olJ0NqetEH/0YanyoRj9Ml1/47M7T3z4fA H4+Yq/XhxJnIL+1oxThx+epNyTDlaBk6IWos7J1unQ8gq46SSmv8UZIzNZ+nUWEs g0Lb4Bq5uDWK2DcFLHGSJLOc91yYKZz23dPcw5W42pCxc6t03tfGIuk7Om6L+iA3 Cc3svUKCfopyP3F+KaJdWUACyy6WAjMHLFhAzYAh0PCLGcnISXKyvvGVSMeRnT9E qk/krS0keL6OUYPA9tI0fI5OT68VSNjiQB/oN0n5aKvgJkKJ3ZpheffudS4WSg5Z VYNBBfSz7FHzn4g9lCc55m83VVeHAnF7u0C0sOzJKhh8eQ7VhIL3mzS7gx4aCTE= =+j15 -----END PGP SIGNATURE----- --M0pppTO7U6Cdw0GMq7GCTUghonxTOrir5--