From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXB1m-0005jz-Ml for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:36:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXB1l-0001qq-CR for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:36:50 -0400 References: <1441183880-26993-1-git-send-email-wency@cn.fujitsu.com> <1441183880-26993-16-git-send-email-wency@cn.fujitsu.com> From: Eric Blake Message-ID: <55E72599.6080107@redhat.com> Date: Wed, 2 Sep 2015 10:36:41 -0600 MIME-Version: 1.0 In-Reply-To: <1441183880-26993-16-git-send-email-wency@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l4xoGdTEtM5jJTqGnGVKR7VB25UCHPkLQ" Subject: Re: [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu devel , Fam Zheng , Max Reitz , Paolo Bonzini , Stefan Hajnoczi Cc: Kevin Wolf , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , "Michael R. Hines" , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l4xoGdTEtM5jJTqGnGVKR7VB25UCHPkLQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/02/2015 02:51 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > qapi/block-core.json | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 96f0530..86275e3 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1383,7 +1383,7 @@ > 'dmg', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',= > 'host_floppy', 'http', 'https', 'null-aio', 'null-co', 'pa= rallels', > 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp', 'vdi', 'v= hdx', > - 'vmdk', 'vpc', 'vvfat', 'nbd' ] } > + 'vmdk', 'vpc', 'vvfat', 'nbd', 'replication' ] } 'nbd' is not in the current qemu.git; which means your patch series depends on a prerequisite series. Please mention that sort of information in your cover letter. Please keep this enum in alphabetical order. Missing documentation under @drv of BlockDeviceInfo that this was introduced in 2.5. > =20 > ## > # @BlockdevOptionsBase > @@ -1825,6 +1825,19 @@ > { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] } > =20 > ## > +# @BlockdevOptionsReplication > +# > +# Driver specific block device options for replication > +# > +# @mode: the replication mode Can the mode be 'unprotected', or must it be 'primary' or 'secondary' when first creating a replication BDS? > +# > +# Since: 2.5 > +## > +{ 'struct': 'BlockdevOptionsReplication', > + 'base': 'BlockdevOptionsGenericFormat', > + 'data': { 'mode': 'ReplicationMode' } } > + > +## > # @BlockdevOptions > # > # Options for creating a block device. > @@ -1869,7 +1882,8 @@ > 'vhdx': 'BlockdevOptionsGenericFormat', > 'vmdk': 'BlockdevOptionsGenericCOWFormat', > 'vpc': 'BlockdevOptionsGenericFormat', > - 'vvfat': 'BlockdevOptionsVVFAT' > + 'vvfat': 'BlockdevOptionsVVFAT', > + 'replication':'BlockdevOptionsReplication' > } } It helps to keep this alphabetical. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --l4xoGdTEtM5jJTqGnGVKR7VB25UCHPkLQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5yWZAAoJEKeha0olJ0NqpasH/1n/v2EP0/+OWMgR0+9Ih57N 20LiJBAWZ9cCNs+QQtSTtgpkvJHYobzeVI33WuDjXyXtDbJCBNlOVNgUIrjtZ3a1 wecux2ZBEUHfG1Be7ATuHlalR0Oh+FG8dNskEQvvw7HXyKFEK9brZzJQRhfct4we 3Evs+h55FoNjTByHnPEetl37ceXcHMsxDSo2TikolemjCsOJtc0BQvVtXDpdxasp E6UZ+sNo54BFRXlG70yLon44woL43NJRf7GlenIsyf7A1ikic85Huf33u7nY3e2J 9igmRNmB8gVbvXQoZUlXNeBcuDQGaaHHT/fx5S+v2QTMD2TGsXU0KcopCqNlizI= =dz4a -----END PGP SIGNATURE----- --l4xoGdTEtM5jJTqGnGVKR7VB25UCHPkLQ--