From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXB4Y-0008SE-Lh for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:39:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXB4T-0002zv-C1 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:39:42 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:59184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXB4T-0002yc-11 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:39:37 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Sep 2015 17:39:33 +0100 Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t82GbHgR34930764 for ; Wed, 2 Sep 2015 16:37:17 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t82GbH7O028930 for ; Wed, 2 Sep 2015 10:37:17 -0600 Message-ID: <55E725BD.4020306@linux.vnet.ibm.com> Date: Wed, 02 Sep 2015 18:37:17 +0200 From: Pierre Morel MIME-Version: 1.0 References: <1441206756-21918-1-git-send-email-pmorel@linux.vnet.ibm.com> <55E71CE9.5090303@redhat.com> In-Reply-To: <55E71CE9.5090303@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] virtio dataplane: adapt dataplane for virtio Version 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 09/02/2015 05:59 PM, Eric Blake wrote: > [meta-comment] > > On 09/02/2015 09:12 AM, Pierre Morel wrote: >> Let dataplane allocate different region for the desc/avail/used >> ring regions. >> Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail >> rings accordingly. > This part is fine. > >> Changes from V2: >> - incorporate the code directly in vring_setup(). >> - added room for the event indexes used with VIRTIO_RING_F_EVENT_IDX >> >> Changes from v1: >> - use a macro to gain LOCs inside of vring_setup() > But the above changelog text belongs better... > >> Signed-off-by: Pierre Morel >> --- > ...here after the '---' separator, where it will be stripped by 'git > am'. It is useful for reviewers of the earlier versions, but in the > long run, when reading 'git log', we will only care about what got > committed, not how many tries it took to get to that point. > Thanks. I do the right thing immediately.