From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXBUf-0004iT-Px for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:06:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXBUc-00065q-F3 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:06:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXBUc-00065m-A4 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:06:38 -0400 References: <1440714174-13261-1-git-send-email-lvivier@redhat.com> <1440714174-13261-2-git-send-email-lvivier@redhat.com> From: Eric Blake Message-ID: <55E72C9C.1080208@redhat.com> Date: Wed, 2 Sep 2015 11:06:36 -0600 MIME-Version: 1.0 In-Reply-To: <1440714174-13261-2-git-send-email-lvivier@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rFAIsxV8n28kVI17Aa7sG0L6HT5WCpH30" Subject: Re: [Qemu-devel] [PATCH v3 2/2] -help lists only -help-* commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , Paolo Bonzini , qemu-devel@nongnu.org, marcandre.lureau@gmail.com Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rFAIsxV8n28kVI17Aa7sG0L6HT5WCpH30 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/27/2015 04:22 PM, Laurent Vivier wrote: > A slight change of behavior: >=20 > -help-all displays all helps (like -help/-h before) > -help/-h lists only the available help commands I like the change. However, I think that it is missing the overall summary; bare help should still include the lead-in lines that mention usage; I'm less concerned if the version line is present (we have --version for that), but it may be easier to include it too. That is, this part from pre-patch should probably still show: $ ./x86_64-softmmu/qemu-system-x86_64 --help QEMU emulator version 2.4.50, Copyright (c) 2003-2008 Fabrice Bellard usage: qemu-system-x86_64 [options] [disk_image] 'disk_image' is a raw hard disk image for IDE hard disk 0 Help/version options: =2E.. >=20 > Signed-off-by: Laurent Vivier > --- > v3: add this patch to add an help section, -help displays only this sec= tion > qemu-options.hx | 29 +++++++++++++++++++++++++---- > vl.c | 12 +++++++++++- > 2 files changed, 36 insertions(+), 5 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rFAIsxV8n28kVI17Aa7sG0L6HT5WCpH30 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5yycAAoJEKeha0olJ0NqtV4H/Rh5al8dxlqn26EkpTla16CK kWHHGM3oMNl/EmC0R15gN8cK6BVCCO32KPYelBW95b9wJTlVrJJ1H+iPTNtxnFYz fb7rYB2NG3HJXidi6gqcRxM9kYlWYSMEiP9RphYRL5QsdcWvhVDr6L5Uv0NhKk5+ TllfC6Zn14TonDDpAwrZtA/1tFoX9VVnprOikj6v9w0RMKhZmfCiYIw4CukWjN3H eW/d6HQAg2ur+OXWdo7CGZ7njjosoW0m72TtlOXssP0eQzsddC33gBNA8+TaMQbs xoxFPM/avcAMqTa5uQthb9KYPqAcGNEWpONAyIDDmbOKQ6p/rGlUwfYLyWtV21E= =C5oU -----END PGP SIGNATURE----- --rFAIsxV8n28kVI17Aa7sG0L6HT5WCpH30--