From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXEF4-00029u-Pn for qemu-devel@nongnu.org; Wed, 02 Sep 2015 16:02:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXEF3-0002fG-Ry for qemu-devel@nongnu.org; Wed, 02 Sep 2015 16:02:46 -0400 References: <1441219948-13242-1-git-send-email-mreitz@redhat.com> <1441219948-13242-4-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <55E755DF.3070506@redhat.com> Date: Wed, 2 Sep 2015 14:02:39 -0600 MIME-Version: 1.0 In-Reply-To: <1441219948-13242-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qs1LH0aBmaPp22Qe8mmSm2jwMNsU6Kfdu" Subject: Re: [Qemu-devel] [PATCH v2 3/4] iotests: Do not suppress segfaults in bash tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Jeff Cody , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Qs1LH0aBmaPp22Qe8mmSm2jwMNsU6Kfdu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/02/2015 12:52 PM, Max Reitz wrote: > Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a > segmentation fault, that message is invisible in most cases since the > output is generally filtered and bash suppresses the segmentation fault= > notice for any but the last element of a pipe. >=20 > Most of the time, the test will then fail anyway because of missing > output, but not necessarily (as happened with test 82 recently). >=20 > Fix this by making the corresponding environment variables point to > wrapper functions which execute the respective command in a subshell. >=20 > Giving options to qemu/qemu-io/qemu-img and path names with spaces were= > broken for the Python tests; this patch "accidentally" fixes that. >=20 > Signed-off-by: Max Reitz > --- Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Qs1LH0aBmaPp22Qe8mmSm2jwMNsU6Kfdu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV51XfAAoJEKeha0olJ0NqfVIH/3hSbgw8f55y8zqQQvEapc6j CQ/3xwCkZC/LgH7B2xDEOKp0fSLWESewBnY5KD9///5yM3K/1De/WQI0L4tOsL1g NwT+9/bZpS6jsX4gpUVz4e5HcGt4HmfJTaT9A1fKkavse4hXGMRIFA1FuL91fq5q +TZnQ/0mL3IhLQrcxX0IlB8KJujocmXpGI4IXMg4Jhn3mO0zZw6D5prm67l9Q591 5HDLlgmlPsga8rTjamZOufa2SQDc7ZVKkOs888hDbOzQ80sLKQNyWkTlhuUGvsZg PffWgIIuaOu7lhGNkvkwsTahDljLFX0cdWDmT0GJLX01m+ObGPfAULY0x3DJzNY= =YS8Y -----END PGP SIGNATURE----- --Qs1LH0aBmaPp22Qe8mmSm2jwMNsU6Kfdu--