From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXU0X-0007Ud-VO for qemu-devel@nongnu.org; Thu, 03 Sep 2015 08:52:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXU0U-0002Hl-Pi for qemu-devel@nongnu.org; Thu, 03 Sep 2015 08:52:49 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:38503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXU0U-0002HI-JZ for qemu-devel@nongnu.org; Thu, 03 Sep 2015 08:52:46 -0400 Received: by wiclk2 with SMTP id lk2so7064752wic.1 for ; Thu, 03 Sep 2015 05:52:44 -0700 (PDT) From: "=?UTF-8?B?S8WRdsOhZ8OzIFpvbHTDoW4=?=" References: <1441275332.557.33.camel@redhat.com> Message-ID: <55E842A5.40007@gmail.com> Date: Thu, 3 Sep 2015 14:52:53 +0200 MIME-Version: 1.0 In-Reply-To: <1441275332.557.33.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 00/49] audio: -audiodev option, multiple options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Markus Armbruster , Stefan Hajnoczi , qemu-devel@nongnu.org, Eduardo Habkost 2015-09-03 12:15 keltezéssel, Gerd Hoffmann írta: > On Fr, 2015-08-21 at 17:36 +0200, Kővágó, Zoltán wrote: >> This patch series adds support to multiple audio backends. Afterwards I >> add support to multiple backends. Audio fronteds gain a new audiodev >> option to specify the id of the audiodev to use. The audiodev= option >> is required, unless you use the old environment variable based >> configuration, in that case it must not used (and you can't use multiple >> backends). >> >> Finally I also make mixeng usage optional, it can save us some useless >> format converting when not needed. Also makes easier to support formats >> currently not supported by qemu (as only the backend has to support it, >> not the mixeng). >> >> For easier testing pull https://github.com/DirtYiCE/qemu.git tag >> audio-multi-v2. >> >> Please review. > > Adding qapi & net folks to Cc. Ping. > > How to go forward with the QAPI bits in this series (Patches 1-9)? > Patch #1 got reviews from block folks. Patch #3 has a comment from > Eduardo pending. What about the other ones? Fine as-is? I remember > from the pre-2.4 freeze discussions that there at least was agreement > that flattening the qapi structs is the way to go. Eduardo's comment was about s/NumaDriver/NumaOptionType/, and I didn't want to resend the whole series just to fix this small problem (as there will be other problems too, I think). IIRC Markus still had opposition with patch #9 (support nested structs in OptsVisitor). Zoltan