From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXXcv-0005Ca-OY for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXXcr-00066C-N8 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:44:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXXcr-00065h-I3 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 12:44:37 -0400 References: <1441220618-4750-1-git-send-email-rjones@redhat.com> <1441220618-4750-2-git-send-email-rjones@redhat.com> <20150903000816-mutt-send-email-mst@redhat.com> <55E862A3.4070702@redhat.com> <55E8646F.20401@msgid.tls.msk.ru> <55E8692B.5070201@redhat.com> <55E8764D.6020302@msgid.tls.msk.ru> From: Laszlo Ersek Message-ID: <55E878F1.5050709@redhat.com> Date: Thu, 3 Sep 2015 18:44:33 +0200 MIME-Version: 1.0 In-Reply-To: <55E8764D.6020302@msgid.tls.msk.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] acpi: Allow ACPI default OEM ID and OEM table ID fields to be set. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , "Michael S. Tsirkin" , "Richard W.M. Jones" Cc: peter.maydell@linaro.org, ehabkost@redhat.com, zhaoshenglong@huawei.com, qemu-devel@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com, rth@twiddle.net On 09/03/15 18:33, Michael Tokarev wrote: > 03.09.2015 18:37, Laszlo Ersek wrote: > [] >> Actually, 6 + 4 + 4 = 14, so OemID and OemTableID. But, you are right, I >> was working off the commit message & comments only, not the actual >> amount of bytes copied. >> >> This ties down both OemID and OemTableId, between all of RSDT, SLIC, and >> FADT. Since >> - I argue against exposing a generic oem_table_id on the command >> line (unlike oem_id), >> - and I also find that an oem_table_id "map" would be overkill, >> >> I think it follows that I can only ask for the special SLIC-handling >> logic already visible in your patch. "User passed in SLIC --> adapt RSDT >> and FADT." That is, it is already user-controlled. > > It might be useful to have it controllable by user in other cases too. > But I don't have any usage case for that. > >> (The FADT change will ensure that OVMF will update the RSDT that *it* >> installs.) >> >> This is just my preference, of course... But at least it doesn't seem to >> conflict with Michael's! :) > > Yes, it might just work. Especially since in case when SLIC is specified, > the oem_table&Co should come from SLIC, not forcing user to specify them > on command line. Command line can be used anyway, with the default value > coming from slic if it is provided. > > BTW, I updated the patch for 2.4 a few days ago, it is hackish as I wanted > to touch as few files as possible. > > And BTW2, the code in acpi/core.c uses its own local definition of ACPI > table data structures, instead of using common code from acpi.h... ;) True, but the SDT header struct in "hw/acpi/core.c" (from 2009-2013) seems to predate the same in "include/hw/acpi/acpi-defs.h" (from Summer 2013) by quite a few years! :) > Thanks, > > /mjt >