From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXbLf-0000Qj-2b for qemu-devel@nongnu.org; Thu, 03 Sep 2015 16:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXbLa-0004UZ-Vd for qemu-devel@nongnu.org; Thu, 03 Sep 2015 16:43:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXbLa-0004UU-QI for qemu-devel@nongnu.org; Thu, 03 Sep 2015 16:43:02 -0400 References: <1441290623-13631-1-git-send-email-armbru@redhat.com> <1441290623-13631-30-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55E8B0D0.4000008@redhat.com> Date: Thu, 3 Sep 2015 14:42:56 -0600 MIME-Version: 1.0 In-Reply-To: <1441290623-13631-30-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aISWb4uxcQ8xD2xqeRLDqXpmR6a563Dhq" Subject: Re: [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unused, drop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aISWb4uxcQ8xD2xqeRLDqXpmR6a563Dhq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/03/2015 08:30 AM, Markus Armbruster wrote: > 'gen': false needs to stay for now, because netdev_add is still using > it. >=20 > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > +++ b/tests/Makefile > @@ -228,7 +228,7 @@ check-qapi-schema-y :=3D $(addprefix tests/qapi-sch= ema/, \ > bad-type-dict.json double-data.json unknown-expr-key.json \ > redefined-type.json redefined-command.json redefined-builtin.json \ > redefined-event.json command-int.json bad-data.json event-max.json \ > - type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \ > + type-bypass-bad-gen.json \ > args-invalid.json \ > args-array-empty.json args-array-unknown.json args-int.json \ > args-unknown.json args-member-unknown.json args-member-array.json \ Not for this patch, but we aren't very consistent on any form of sorting or line length in this section. It might be nicer if it were one test per line (lots more line continuations) and/or alphabetical order. If that sounds nice, then it's a trivial patch to add in as one of the followups after this series lands. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aISWb4uxcQ8xD2xqeRLDqXpmR6a563Dhq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV6LDQAAoJEKeha0olJ0Nqt1EIAIFxRR3MQFWwndTxEhfgOPaV OGkdcHLqchy7O5YRgsu/CYAiauYHsHLbcbjNaY6I+XXLNd+nh6wlmeIhuoagBgXk gQgrGtUluzIdFwiaub8XZr8XzRh8UDea6ZljBSHDS7HOitrQGJMkeLoQu2Zl4Wtt 1FhKdN7ZnzQ6mjhM/SN7/PocHRLhU//RX4Te3cm6gM1a+EhD1TI3bULeH0DLoBlo PN9dYtRlTsXCRX8YdDG7cJK3RwsvFcmNdZQI5FyHQaAZlIYKhRBfEBbyBg0IHsey 1VxCuSdUS5HiTBQ3QHGB4vHspZprWD/EyA0bwnY6bj/LaXZl+8WFustTo2zxQKE= =tTX2 -----END PGP SIGNATURE----- --aISWb4uxcQ8xD2xqeRLDqXpmR6a563Dhq--