From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1ZXqg5-00026D-QR
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 09:05:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1ZXqg0-0003Ut-Ce
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 09:05:13 -0400
Received: from mail.uni-paderborn.de ([131.234.142.9]:47126)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kbastian@mail.uni-paderborn.de>) id 1ZXqg0-0003UR-5M
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 09:05:08 -0400
References: <1441239463-18981-1-git-send-email-rth@twiddle.net>
	<1441239463-18981-7-git-send-email-rth@twiddle.net>
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Message-ID: <55E996FE.5040506@mail.uni-paderborn.de>
Date: Fri, 4 Sep 2015 15:05:02 +0200
MIME-Version: 1.0
In-Reply-To: <1441239463-18981-7-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/17] target-openrisc: Put SR[OVE] in TB
 flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, proljc@gmail.com



On 09/03/2015 02:17 AM, Richard Henderson wrote:
>   {
>       /* Sync the tb dependent flag between translate and runtime.  */
> -    if (dc->tb_flags != dc->synced_flags) {
> -        tcg_gen_movi_tl(env_flags, dc->tb_flags);
> +    if ((dc->tb_flags ^ dc->synced_flags) & D_FLAG) {
> +        tcg_gen_movi_tl(env_flags, dc->tb_flags & D_FLAG);
>           dc->synced_flags = dc->tb_flags;
>       }
>   }
Why do we only need to sync D_FLAG? Will there only be D_FLAG, which 
needs to be synced?

Cheers,
Bastian