Re: [Qemu-devel] [PATCH 07/17] target-openrisc: Keep SR_CY and SR_OV in a separate variables

[Bastian Koppelmann <kbastian@mail.uni-paderborn.de>]

On 09/03/2015 02:17 AM, Richard Henderson wrote:
> -
> -uint32_t HELPER(mul32)(CPUOpenRISCState *env,
> -                       uint32_t ra, uint32_t rb)
> -{
> -    uint64_t result;
> -    uint32_t high, cy;
> -
> -    OpenRISCCPU *cpu = openrisc_env_get_cpu(env);
> -
> -    result = (uint64_t)ra * rb;
> -    /* regisiers in or32 is 32bit, so 32 is NOT a magic number.
> -       or64 is not handled in this function, and not implement yet,
> -       TARGET_LONG_BITS for or64 is 64, it will break this function,
> -       so, we didn't use TARGET_LONG_BITS here.  */
> -    high = result >> 32;
> -    cy = result >> (32 - 1);
> -
> -    if ((cy & 0x1) == 0x0) {
> -        if (high == 0x0) {
> -            return result;
> -        }
> -    }
> -
> -    if ((cy & 0x1) == 0x1) {
> -        if (high == 0xffffffff) {
> -            return result;
> -        }
> -    }
> -
> -    cpu->env.sr |= (SR_OV | SR_CY);
> -    if (cpu->env.sr & SR_OVE) {
> -        raise_exception(cpu, EXCP_RANGE);
> -    }
> -
> -    return result;
> -}
This ought to be part of patch 02, where you removed the last use of 
helper_mul32.

Other than that,
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian