From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZXrzL-0008CB-HG
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 10:29:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZXrzI-0005QV-AU
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 10:29:11 -0400
Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:34896)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZXrzI-0005QK-6Q
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 10:29:08 -0400
Received: by qgt47 with SMTP id 47so17029787qgt.2
	for <qemu-devel@nongnu.org>; Fri, 04 Sep 2015 07:29:07 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1441239463-18981-1-git-send-email-rth@twiddle.net>
	<1441239463-18981-7-git-send-email-rth@twiddle.net>
	<55E996FE.5040506@mail.uni-paderborn.de>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55E9AAAF.7020609@twiddle.net>
Date: Fri, 4 Sep 2015 07:29:03 -0700
MIME-Version: 1.0
In-Reply-To: <55E996FE.5040506@mail.uni-paderborn.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/17] target-openrisc: Put SR[OVE] in TB
 flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, proljc@gmail.com

On 09/04/2015 06:05 AM, Bastian Koppelmann wrote:
>
>
> On 09/03/2015 02:17 AM, Richard Henderson wrote:
>>   {
>>       /* Sync the tb dependent flag between translate and runtime.  */
>> -    if (dc->tb_flags != dc->synced_flags) {
>> -        tcg_gen_movi_tl(env_flags, dc->tb_flags);
>> +    if ((dc->tb_flags ^ dc->synced_flags) & D_FLAG) {
>> +        tcg_gen_movi_tl(env_flags, dc->tb_flags & D_FLAG);
>>           dc->synced_flags = dc->tb_flags;
>>       }
>>   }
> Why do we only need to sync D_FLAG? Will there only be D_FLAG, which needs to
> be synced?

It's a somewhat silly way to mark the delayed branch status.  I don't recall if 
I eventually got around to fixing this or not.


r~