From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsd7-00088K-Vt for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:10:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXsd3-0002mM-D0 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:10:17 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:38272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsd3-0002m8-8I for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:10:13 -0400 Received: from /spool/local by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Sep 2015 11:10:12 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id D4C7AC90048 for ; Fri, 4 Sep 2015 11:01:13 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t84FA9aH58065030 for ; Fri, 4 Sep 2015 15:10:09 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t84FA9mS024368 for ; Fri, 4 Sep 2015 11:10:09 -0400 Message-ID: <55E9B43A.7070304@linux.vnet.ibm.com> Date: Fri, 04 Sep 2015 11:09:46 -0400 From: "Jason J. Herne" MIME-Version: 1.0 References: <1441118763-17510-1-git-send-email-jjherne@linux.vnet.ibm.com> <1441118763-17510-3-git-send-email-jjherne@linux.vnet.ibm.com> <55E6181D.3080709@redhat.com> In-Reply-To: <55E6181D.3080709@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 2/5] migration: Parameters for auto-converge cpu throttling Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , afaerber@suse.de, amit.shah@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com On 09/01/2015 05:26 PM, Eric Blake wrote: > On 09/01/2015 08:46 AM, Jason J. Herne wrote: >> Add migration parameters to allow the user to adjust the parameters >> that control cpu throttling when auto-converge is in effect. The added >> parameters are as follows: >> >> x-cpu-throttle-initial : Initial percantage of time guest cpus are throttled >> when migration auto-converge is activated. >> >> x-cpu-throttle-increment: throttle percantage increase each time >> auto-converge detects that migration is not making progress. > > Marked experimental; do we think it will be promoted to stable before > 2.5 is released? > Not a clue :) I have no idea how things move from x- to sans x-. > What happens if I set throttle-initial to 50 and throttle-increment to > 50? The previous patch required throttle percentage to be between 1 and > 99 inclusive; does that mean I cap out at 99 instead of an invalid > throttle of 100? > The call to cpu_throttle_set will take care of the capping. Details provided in previous reply :) ... > We've missed 2.4; these lines need to say (Since 2.5). ... >> # Since: 2.4 ... > Would be nice to document the default (20). ... > And again (10). Also, same comment about needing 2.5. > I will fix all of these. -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)