qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc
Date: Fri, 4 Sep 2015 13:43:56 -0600	[thread overview]
Message-ID: <55E9F47C.8080807@redhat.com> (raw)
In-Reply-To: <1441395661-22447-1-git-send-email-marcandre.lureau@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

On 09/04/2015 01:41 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> The legacy<> type is no longer used since 7ce7ffe02.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  qapi-schema.json | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)

> @@ -1689,10 +1686,10 @@
>  #
>  # @property: The property name to read
>  #
> -# Returns: The property value.  The type depends on the property type.  legacy<>
> -#          properties are returned as #str.  child<> and link<> properties are
> -#          returns as #str pathnames.  All integer property types (u8, u16, etc)
> -#          are returned as #int.
> +# Returns: The property value.  The type depends on the property
> +#          type. child<> and link<> properties are returns as #str

While at it, please fix the pre-existing typo:

s/returns/returned/

> +#          pathnames.  All integer property types (u8, u16, etc) are
> +#          returned as #int.

With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-09-04 19:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 19:41 [Qemu-devel] [PATCH] qapi-schema: remove legacy<> from doc marcandre.lureau
2015-09-04 19:43 ` Eric Blake [this message]
2015-09-11  7:16 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E9F47C.8080807@redhat.com \
    --to=eblake@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).