Re: [Qemu-devel] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

On 04.09.2015 19:18, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/137     | 143 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/137.out |  43 ++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 187 insertions(+)
>  create mode 100755 tests/qemu-iotests/137
>  create mode 100644 tests/qemu-iotests/137.out
> 
> diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137
> new file mode 100755
> index 0000000..ad52f71
> --- /dev/null
> +++ b/tests/qemu-iotests/137


[snip]

> +echo
> +echo === Try setting some invalid values ===
> +echo
> +
> +$QEMU_IO \
> +    -c "reopen -o lazy-refcounts=42" \
> +    -c "reopen -o cache-size=1M,l2-cache-size=64k,refcount-cache-size=64k" \
> +    -c "reopen -o cache-size=1M,l2-cache-size=2M" \
> +    -c "reopen -o cache-size=1M,refcount-cache-size=2M" \
> +    -c "reopen -o l2-cache-size=256T" \
> +    -c "reopen -o l2-cache-size=64G" \

Testing this seems risky. The rest looks fine, but I'm not sure whether
this is really needed so much that we should risk the test failing on
some machines, especially in the future.

Or actually even on my machine:

$ touch ~/tmp/swap
$ truncate ~/tmp/swap --size 128G
$ fallocate -l 128G ~/tmp/swap
# mkswap ~maxx/tmp/swap
# swapon ~max/tmp/swap

$ cd /to/qemu/build
$ ./qemu-io -c 'reopen -o l2-cache-size=64G' test.qcow2
$

(Running the test itself is apparently a bad idea, because then for some
reason Linux thinks I actually want to use the swap and everything slows
down to a crawl)

Max

> +    -c "reopen -o refcount-cache-size=256T" \
> +    -c "reopen -o refcount-cache-size=64G" \
> +    -c "reopen -o overlap-check=constant,overlap-check.template=all" \
> +    -c "reopen -o overlap-check=blubb" \
> +    -c "reopen -o overlap-check.template=blubb" \
> +    "$TEST_IMG" | _filter_qemu_io
> +

[snip]


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]