From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXx2Q-0005n8-SM for qemu-devel@nongnu.org; Fri, 04 Sep 2015 15:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXx2P-0005Bc-PG for qemu-devel@nongnu.org; Fri, 04 Sep 2015 15:52:42 -0400 References: <1441387117-27072-1-git-send-email-kwolf@redhat.com> <1441387117-27072-14-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <55E9F67D.9010909@redhat.com> Date: Fri, 4 Sep 2015 21:52:29 +0200 MIME-Version: 1.0 In-Reply-To: <1441387117-27072-14-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CNWxh8B6GD2ohEA2s7Rxb72B5s4CGxDgV" Subject: Re: [Qemu-devel] [PATCH v2 13/13] qemu-iotests: More qcow2 reopen tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CNWxh8B6GD2ohEA2s7Rxb72B5s4CGxDgV Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.09.2015 19:18, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/137 | 143 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/137.out | 43 ++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 187 insertions(+) > create mode 100755 tests/qemu-iotests/137 > create mode 100644 tests/qemu-iotests/137.out >=20 > diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 > new file mode 100755 > index 0000000..ad52f71 > --- /dev/null > +++ b/tests/qemu-iotests/137 [snip] > +echo > +echo =3D=3D=3D Try setting some invalid values =3D=3D=3D > +echo > + > +$QEMU_IO \ > + -c "reopen -o lazy-refcounts=3D42" \ > + -c "reopen -o cache-size=3D1M,l2-cache-size=3D64k,refcount-cache-s= ize=3D64k" \ > + -c "reopen -o cache-size=3D1M,l2-cache-size=3D2M" \ > + -c "reopen -o cache-size=3D1M,refcount-cache-size=3D2M" \ > + -c "reopen -o l2-cache-size=3D256T" \ > + -c "reopen -o l2-cache-size=3D64G" \ Testing this seems risky. The rest looks fine, but I'm not sure whether this is really needed so much that we should risk the test failing on some machines, especially in the future. Or actually even on my machine: $ touch ~/tmp/swap $ truncate ~/tmp/swap --size 128G $ fallocate -l 128G ~/tmp/swap # mkswap ~maxx/tmp/swap # swapon ~max/tmp/swap $ cd /to/qemu/build $ ./qemu-io -c 'reopen -o l2-cache-size=3D64G' test.qcow2 $ (Running the test itself is apparently a bad idea, because then for some reason Linux thinks I actually want to use the swap and everything slows down to a crawl) Max > + -c "reopen -o refcount-cache-size=3D256T" \ > + -c "reopen -o refcount-cache-size=3D64G" \ > + -c "reopen -o overlap-check=3Dconstant,overlap-check.template=3Dal= l" \ > + -c "reopen -o overlap-check=3Dblubb" \ > + -c "reopen -o overlap-check.template=3Dblubb" \ > + "$TEST_IMG" | _filter_qemu_io > + [snip] --CNWxh8B6GD2ohEA2s7Rxb72B5s4CGxDgV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV6fZ+AAoJEDuxQgLoOKytd6YIAKumkgPbioqeqE3To4PwQryI AUe5DUOkps5EzRrVVbSKfNYYAFDlQTA7WO0GHF5eIPHSgkLTzB8pmf2Fl/Dxkz6I 1PQT6yPJMbpj2OZFDox5coKPVZmsoLAAGX7axm0NBHxIpstZbuuePcPSRQ/ZKWrP TmJgaolgBLNxC8UNaXF5fg6AYbDNIFM2Z8eySIpaukcYAW2o0P1n2v9KoeRd+Kl8 nam4hMJ6vMxN9T8LvjB2+5zv6WlwjhzB42DGwBtJASq+Zt6dDgz+iC7FkD/8Ki8i hbdVIhmTmN9rAoIPrN4WcvzVlkVCf8GoC4goX7KaAHQxNNMRhr5doOdhW+lLShc= =3k9H -----END PGP SIGNATURE----- --CNWxh8B6GD2ohEA2s7Rxb72B5s4CGxDgV--