From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXyeu-0004gc-JA for qemu-devel@nongnu.org; Fri, 04 Sep 2015 17:36:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXyeq-0005XK-Ip for qemu-devel@nongnu.org; Fri, 04 Sep 2015 17:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXyeq-0005Ws-D9 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 17:36:28 -0400 References: From: Eric Blake Message-ID: <55EA0ED2.50105@redhat.com> Date: Fri, 4 Sep 2015 15:36:18 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gnlQATDBHiSnt4QlhTscStgIX8rLe7hSk" Subject: Re: [Qemu-devel] [PATCH v2 05/49] net: use Netdev instead of NetClientOptions in client init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Vincenzo Maffione , Gerd Hoffmann , Stefan Hajnoczi , Giuseppe Lettieri , Luigi Rizzo This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gnlQATDBHiSnt4QlhTscStgIX8rLe7hSk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/21/2015 09:37 AM, K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n wrote: > This way we no longer need NetClientOptions and can convert Netdev > into a flat union. >=20 > Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n > --- > net/clients.h | 20 ++++++++++---------- > net/dump.c | 6 +++--- > net/hub.c | 6 +++--- > net/l2tpv3.c | 6 +++--- > net/net.c | 29 ++++++++++++++--------------- > net/netmap.c | 4 ++-- > net/slirp.c | 6 +++--- > net/socket.c | 6 +++--- > net/tap-win32.c | 6 +++--- > net/tap.c | 12 ++++++------ > net/vde.c | 6 +++--- > net/vhost-user.c | 6 +++--- > 12 files changed, 56 insertions(+), 57 deletions(-) Nice; you've already done some of the work that I saw as needing to be done for my plans to convert QMP netdev_add to use a flat union instead of 'gen':false. Conflicts with my s/kind/type/ in https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02061.html, so whoever goes in first gets to avoid the obvious merge conflict resolution. :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gnlQATDBHiSnt4QlhTscStgIX8rLe7hSk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV6g7SAAoJEKeha0olJ0NqcpkH/RTKN50Q6dW4rz6+VXs7xqSO RaVLfxFxu+HjzPikHB3P7GcNnhdIQSChJifIZxkBHhqZ95HpH5BzcS0L9hyVPIJK oBv5HDgW0p7OTS1JZKZlVqC0dFaquUoVAFkoTOZOFcfiH4Zah3pkpbur7WHY7oY/ eHsK3ppY4Z5G2wIHK40KUGbumf2G6b1a3PtfIZfEG5IyU82Q/9XeuVYma5CZH/KC gQxMolaBc/x18Bj1uchsuyOvVZov8xCSGHQgidPeNXrgtJc7vbUK8nTCLfgIQwGG TIiu/qnjcxvySfI7SS9VGJZn8MSBFYCpTX8xBHnhAuoDsH79WxWFp488N5otv4k= =Lztd -----END PGP SIGNATURE----- --gnlQATDBHiSnt4QlhTscStgIX8rLe7hSk--