From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1ZXzoa-0000eN-B5
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 18:50:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1ZXzoW-0004of-7H
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 18:50:36 -0400
Received: from greensocs.com ([193.104.36.180]:56884)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1ZXzoV-0004oI-QL
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 18:50:32 -0400
Message-ID: <55EA2034.7050908@greensocs.com>
Date: Sat, 05 Sep 2015 00:50:28 +0200
From: Frederic Konrad <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1437499031-11741-1-git-send-email-fred.konrad@greensocs.com>
	<1437499031-11741-2-git-send-email-fred.konrad@greensocs.com>
	<CAKmqyKOQYMMHEcm=yOmMKjy-7gSSDhuQHEnBFu8YXdK+2dKyGg@mail.gmail.com>
In-Reply-To: <CAKmqyKOQYMMHEcm=yOmMKjy-7gSSDhuQHEnBFu8YXdK+2dKyGg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alistair Francis <alistair23@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, hyunk@xilinx.com, mark.burton@greensocs.com, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, guillaume.delbergue@greensocs.com

On 01/09/2015 22:58, Alistair Francis wrote:
> On Tue, Jul 21, 2015 at 10:17 AM,  <fred.konrad@greensocs.com> wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> Seems this field is not needed.
> The commit message should be updated to represent the patch.
Hmmm what do you mean?
It's not precise?

Thanks,
Fred

>
>> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> Otherwise:
>
> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
>
> Thanks,
>
> Alistair
>
>> ---
>>   hw/i2c/core.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/i2c/core.c b/hw/i2c/core.c
>> index 5a64026..e0f92de 100644
>> --- a/hw/i2c/core.c
>> +++ b/hw/i2c/core.c
>> @@ -13,7 +13,6 @@ struct I2CBus
>>   {
>>       BusState qbus;
>>       I2CSlave *current_dev;
>> -    I2CSlave *dev;
>>       uint8_t saved_address;
>>   };
>>
>> --
>> 1.9.0
>>
>>