Re: [Qemu-devel] [PATCH v2 09/49] qapi: support nested structs in OptsVisitor

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote:
> The current OptsVisitor flattens the whole structure, if there are same
> named fields under different paths (like `in' and `out' in `Audiodev'),
> the current visitor can't cope with them (for example setting
> `frequency=44100' will set the in's frequency to 44100 and leave out's
> frequency unspecified).
> 
> This patch fixes it, by always requiring a complete path in case of
> nested structs.  Fields in the path are separated by dots, similar to C
> structs (without pointers), like `in.frequency' or`out.frequency'.

s/or`out/or `out/

> 
> You must provide a full path even in non-ambigous cases.  The qapi

s/ambigous/ambiguous/

> flattening commits hopefully ensures that this change doesn't create
> backward compatibility problems.

Give me some more time to think about 8 and 9 (it's nearly the start of
a 3-day weekend for me). I know I said I'd look at these patches before
Monday, but for now you'll have to live with my review on just 1-7.  Oh
well. I know what I'm starting on next week when I return :)

And we still have plenty of time before qemu 2.5 to get things right.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]