From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZY0Ij-0005GN-T8 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 19:21:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZY0Ig-0004XH-QU for qemu-devel@nongnu.org; Fri, 04 Sep 2015 19:21:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZY0Ig-0004XD-LT for qemu-devel@nongnu.org; Fri, 04 Sep 2015 19:21:42 -0400 References: From: Eric Blake Message-ID: <55EA2784.3080508@redhat.com> Date: Fri, 4 Sep 2015 17:21:40 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6C2usfBt0jS4C0Ab8ovoPcuw2k6UIqqoq" Subject: Re: [Qemu-devel] [PATCH v2 09/49] qapi: support nested structs in OptsVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , qemu-devel@nongnu.org Cc: Markus Armbruster , Michael Roth , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6C2usfBt0jS4C0Ab8ovoPcuw2k6UIqqoq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/21/2015 09:37 AM, K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n wrote: > The current OptsVisitor flattens the whole structure, if there are same= > named fields under different paths (like `in' and `out' in `Audiodev'),= > the current visitor can't cope with them (for example setting > `frequency=3D44100' will set the in's frequency to 44100 and leave out'= s > frequency unspecified). >=20 > This patch fixes it, by always requiring a complete path in case of > nested structs. Fields in the path are separated by dots, similar to C= > structs (without pointers), like `in.frequency' or`out.frequency'. s/or`out/or `out/ >=20 > You must provide a full path even in non-ambigous cases. The qapi s/ambigous/ambiguous/ > flattening commits hopefully ensures that this change doesn't create > backward compatibility problems. Give me some more time to think about 8 and 9 (it's nearly the start of a 3-day weekend for me). I know I said I'd look at these patches before Monday, but for now you'll have to live with my review on just 1-7. Oh well. I know what I'm starting on next week when I return :) And we still have plenty of time before qemu 2.5 to get things right. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6C2usfBt0jS4C0Ab8ovoPcuw2k6UIqqoq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV6ieEAAoJEKeha0olJ0NqZUoIAKSV3SbiuNwlowBoOTzzn5uO 29jZalQZjeDU1o/CR/75cpC2iwFOffzcXWVSRWqaKb0iWfyfOLv6WjDct4Uc/vxb 1q8zaCqmAbNppgxSiuR95rWDngKJTdZfENkKUScSL02UAVQkuqs3fg77eCx8ZefV x0e9pInIy6FMiqXULgfVQn9pj2y8f510swBRreuIm1vTRU2udQy1ileVnmk93Kfc KLeRaBHUFVemo8El2MHFd6sbLYFstDuQIF3KHWM5VTCEgg+C4rkw7gm7pPFYuSwX zoKlqsXz4Sw44n7/kttWU1EnWf5k8bzcRc3Dnh0hn0YYCOL+5R5XSTnWUW7C2Co= =obrE -----END PGP SIGNATURE----- --6C2usfBt0jS4C0Ab8ovoPcuw2k6UIqqoq--