From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYCmw-00034H-Cw for qemu-devel@nongnu.org; Sat, 05 Sep 2015 08:41:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYCmt-00044L-7L for qemu-devel@nongnu.org; Sat, 05 Sep 2015 08:41:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYCmt-00043R-0A for qemu-devel@nongnu.org; Sat, 05 Sep 2015 08:41:43 -0400 References: <1441444376-4947-1-git-send-email-saipava@xilinx.com> From: Eric Blake Message-ID: <55EAE2FD.8060009@redhat.com> Date: Sat, 5 Sep 2015 06:41:33 -0600 MIME-Version: 1.0 In-Reply-To: <1441444376-4947-1-git-send-email-saipava@xilinx.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="68mt5xDxsTQdISPhW1fnUHG5gA0B8c1Gs" Subject: Re: [Qemu-devel] [PATCH V2] sdhci: use PRIx64 for uint64_t type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sai Pavan Boddu , qemu-devel@nongnu.org, crosthwaitepeter@gmail.com, peter.maydell@linaro.org Cc: Sai Pavan Boddu , edgari@xilinx.com, alistai@xilinx.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --68mt5xDxsTQdISPhW1fnUHG5gA0B8c1Gs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/05/2015 03:12 AM, Sai Pavan Boddu wrote: > Fix compile time warnings, because of type mismatch for unsigned long > long type. >=20 > Signed-off-by: Sai Pavan Boddu > --- > Changes for V2: > Fix commit message. > Correct line lenght. > --- > +#include > #include "hw/hw.h" > #include "sysemu/block-backend.h" > #include "sysemu/blockdev.h" > @@ -719,7 +720,8 @@ static void sdhci_do_adma(SDHCIState *s) > break; > case SDHC_ADMA_ATTR_ACT_LINK: /* link to next descriptor tab= le */ > s->admasysaddr =3D dscr.addr; > - DPRINT_L1("ADMA link: admasysaddr=3D0x%lx\n", s->admasysad= dr); > + DPRINT_L1("ADMA link: admasysaddr=3D0x%" PRIx64 "\n", > + s->admasysaddr); Please also fix the real problem. This sort of bitrot will keep occurring unless DPRINT_L1() is fixed to unconditionally compile its arguments. In other words, do something like: #define DPRINT_L1(fmt, ...) \ do { \ if (SDHC_DEBUG) { \ fprintf(stderr, "QEMU SDHC: " fmt, ##__VA_ARGS__); \ } \ } while (0) #define DPRINT_L2(fmt, ...) \ do { \ if (SDHC_DEBUG > 1) { \ fprintf(stderr, "QEMU SDHC: " fmt, ##__VA_ARGS__); \ } \ } while (0) #define ERRPRINT(fmt, ...) \ do { if (SDHC_DEBUG) { \ fprintf(stderr, "QEMU SDHC ERROR: " fmt, ##__VA_ARGS__); \ } \ } while (0) rather than the current junk that eliminates the fprintf entirely when SDHC_DEBUG is at its default of 0. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --68mt5xDxsTQdISPhW1fnUHG5gA0B8c1Gs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV6uL9AAoJEKeha0olJ0NqA9IH/3AEmoJF8EbGC+WccG6PK/Bn 58UH/TV+n8B1YNuIiM688SF+gFT3gHMMDVEAEad+Va6hWezbTERpd7MoLiAKMnTP DihQK/UEp74/xk46WkUn3HkU+VUvLA5ESaLRkupLUX5KU8YTDXmmz6Gh8/rmOtKe +BXspOM4GquRyHwzl+DHCzbq9Vs1ADIdnAoLOpHOoCVn8qT2iAkrbWNXm++u5iXZ uYisQ7iScU5K+aWcXhHHBXPf7EseL10+0n9NpAQTObmYPzUTueijaJwGZzCIpK0y BdZyS6dtdGN5sC6oSXuCZ5Y6uG87sxAhYtzoCDXfcz65Iv7JIDgy4j6iiIxuFkk= =AgqL -----END PGP SIGNATURE----- --68mt5xDxsTQdISPhW1fnUHG5gA0B8c1Gs--