qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gonglei <arei.gonglei@huawei.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path
Date: Sun, 6 Sep 2015 15:10:59 +0800	[thread overview]
Message-ID: <55EBE703.1030904@huawei.com> (raw)
In-Reply-To: <1440553971-11108-1-git-send-email-arei.gonglei@huawei.com>

On 2015/8/26 9:52, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> vhost-scsi bootindex does't work because Qemu passes
> wrong fireware path to seabios.
> 
> before:
>   /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0
> after applying the patch:
>   /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0
> 
> Reported-by: Subo <subo7@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/scsi/vhost-scsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index 7eacca9..bac9ddb 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus,
>  {
>      VHostSCSI *s = VHOST_SCSI(dev);
>      /* format: channel@channel/vhost-scsi@target,lun */
> -    return g_strdup_printf("channel@%x/%s@%x,%x", s->channel,
> +    return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel,
>                             qdev_fw_name(dev), s->target, s->lun);
>  }
>  
> 

Ping...

  parent reply	other threads:[~2015-09-06  7:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26  1:52 [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path arei.gonglei
2015-08-26  1:56 ` Gonglei
2015-09-06  7:10 ` Gonglei [this message]
2015-09-07 16:18 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55EBE703.1030904@huawei.com \
    --to=arei.gonglei@huawei.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).