* [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path
@ 2015-08-26 1:52 arei.gonglei
2015-08-26 1:56 ` Gonglei
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: arei.gonglei @ 2015-08-26 1:52 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Gonglei, peter.huangpeng
From: Gonglei <arei.gonglei@huawei.com>
vhost-scsi bootindex does't work because Qemu passes
wrong fireware path to seabios.
before:
/pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0
after applying the patch:
/pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0
Reported-by: Subo <subo7@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
hw/scsi/vhost-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index 7eacca9..bac9ddb 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
@@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus,
{
VHostSCSI *s = VHOST_SCSI(dev);
/* format: channel@channel/vhost-scsi@target,lun */
- return g_strdup_printf("channel@%x/%s@%x,%x", s->channel,
+ return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel,
qdev_fw_name(dev), s->target, s->lun);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path
2015-08-26 1:52 [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path arei.gonglei
@ 2015-08-26 1:56 ` Gonglei
2015-09-06 7:10 ` Gonglei
2015-09-07 16:18 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Gonglei @ 2015-08-26 1:56 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, peter.huangpeng, qemu-stable@nongnu.org
On 2015/8/26 9:52, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> vhost-scsi bootindex does't work because Qemu passes
> wrong fireware path to seabios.
>
> before:
> /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0
> after applying the patch:
> /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0
>
> Reported-by: Subo <subo7@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/scsi/vhost-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Cc: qemu-stable@nongnu.org
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index 7eacca9..bac9ddb 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus,
> {
> VHostSCSI *s = VHOST_SCSI(dev);
> /* format: channel@channel/vhost-scsi@target,lun */
> - return g_strdup_printf("channel@%x/%s@%x,%x", s->channel,
> + return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel,
> qdev_fw_name(dev), s->target, s->lun);
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path
2015-08-26 1:52 [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path arei.gonglei
2015-08-26 1:56 ` Gonglei
@ 2015-09-06 7:10 ` Gonglei
2015-09-07 16:18 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Gonglei @ 2015-09-06 7:10 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, peter.huangpeng
On 2015/8/26 9:52, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> vhost-scsi bootindex does't work because Qemu passes
> wrong fireware path to seabios.
>
> before:
> /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0
> after applying the patch:
> /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0
>
> Reported-by: Subo <subo7@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/scsi/vhost-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index 7eacca9..bac9ddb 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus,
> {
> VHostSCSI *s = VHOST_SCSI(dev);
> /* format: channel@channel/vhost-scsi@target,lun */
> - return g_strdup_printf("channel@%x/%s@%x,%x", s->channel,
> + return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel,
> qdev_fw_name(dev), s->target, s->lun);
> }
>
>
Ping...
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path
2015-08-26 1:52 [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path arei.gonglei
2015-08-26 1:56 ` Gonglei
2015-09-06 7:10 ` Gonglei
@ 2015-09-07 16:18 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2015-09-07 16:18 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: peter.huangpeng
On 26/08/2015 03:52, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> vhost-scsi bootindex does't work because Qemu passes
> wrong fireware path to seabios.
>
> before:
> /pci@i0cf8/scsi@7channel@0/vhost-scsi@0,0
> after applying the patch:
> /pci@i0cf8/scsi@7/channel@0/vhost-scsi@0,0
>
> Reported-by: Subo <subo7@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> hw/scsi/vhost-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index 7eacca9..bac9ddb 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -292,7 +292,7 @@ static char *vhost_scsi_get_fw_dev_path(FWPathProvider *p, BusState *bus,
> {
> VHostSCSI *s = VHOST_SCSI(dev);
> /* format: channel@channel/vhost-scsi@target,lun */
> - return g_strdup_printf("channel@%x/%s@%x,%x", s->channel,
> + return g_strdup_printf("/channel@%x/%s@%x,%x", s->channel,
> qdev_fw_name(dev), s->target, s->lun);
> }
>
>
I was on vacation. :) Thanks, I applied this now.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-07 16:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-26 1:52 [Qemu-devel] [PATCH] vhost-scsi: fix wrong vhost-scsi firmware path arei.gonglei
2015-08-26 1:56 ` Gonglei
2015-09-06 7:10 ` Gonglei
2015-09-07 16:18 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).