From: Michael Tokarev <mjt@tls.msk.ru>
To: "\"Kővágó, Zoltán\"" <dirty.ice.hu@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Qemu Block layer core <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print
Date: Sun, 06 Sep 2015 14:01:28 +0300 [thread overview]
Message-ID: <55EC1D08.3090502@msgid.tls.msk.ru> (raw)
In-Reply-To: <cff8241a8e30f0d39e0f50a435965cdd130cd5d5.1436279924.git.DirtY.iCE.hu@gmail.com>
07.07.2015 17:42, Kővágó, Zoltán wrote:
> This will let us print options in a format that the user would actually
> write it on the command line (foo=bar,baz=asd,etc=def), without
> prepending a spurious comma at the beginning of the list, or quoting
> values unnecessarily. This patch provides the following changes:
> * write and id=, if the option has an id
> * do not print separator before the first element
> * do not quote string arguments
> * properly escape commas (,) for QEMU
Applied to -trivial, thank you!
/mjt
prev parent reply other threads:[~2015-09-06 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 14:42 [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print Kővágó, Zoltán
2015-07-28 12:30 ` Stefan Hajnoczi
2015-08-26 13:15 ` Markus Armbruster
2015-08-26 22:31 ` Kővágó Zoltán
2015-08-28 10:04 ` Markus Armbruster
2015-08-20 14:57 ` Marc-André Lureau
2015-09-06 11:01 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EC1D08.3090502@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=armbru@redhat.com \
--cc=dirty.ice.hu@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).