From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYf6c-0007ip-QK for qemu-devel@nongnu.org; Sun, 06 Sep 2015 14:55:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYf6Z-0004yB-K8 for qemu-devel@nongnu.org; Sun, 06 Sep 2015 14:55:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:39978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYf6Z-0004y5-EL for qemu-devel@nongnu.org; Sun, 06 Sep 2015 14:55:55 -0400 References: <1440525646-22428-1-git-send-email-armbru@redhat.com> <87zj13vmud.fsf@blackfin.pond.sub.org> <55E85A5D.1040809@redhat.com> <878u8no4wu.fsf@blackfin.pond.sub.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <55EC8C39.1030901@suse.de> Date: Sun, 6 Sep 2015 20:55:53 +0200 MIME-Version: 1.0 In-Reply-To: <878u8no4wu.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] qom: Fix misuse of Error API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Eric Blake Cc: qemu-devel@nongnu.org Am 03.09.2015 um 18:15 schrieb Markus Armbruster: > Eric Blake writes: >> On 09/03/2015 04:06 AM, Markus Armbruster wrote: >>> Ping? >>> >>> My "qapi: QMP introspection" series fails "make check" without these >>> fixes. >>> >>> Markus Armbruster writes: >>> >>>> v1 was posted for possible inclusion into 2.4, but the maintainer >>>> didn't bite ;-) >>>> >>>> v2: >>>> * Commit messages updated. >>>> >>>> Markus Armbruster (2): >>>> qom: Do not reuse errp after a possible error >>>> qom: Fix invalid error check in property_get_str() >> >> Were you waiting for further review, or for the maintainer to speak up= ? >=20 > The latter. Andreas spoke up on IRC, and I hope he can get to this > small series in the next few days. Applied to qom-next, with stylistic changes to keep opaque variables firs= t. https://github.com/afaerber/qemu-cpu/commits/qom-next Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)