From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYtAb-0004tx-Ts for qemu-devel@nongnu.org; Mon, 07 Sep 2015 05:57:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYtAY-0008IX-Ko for qemu-devel@nongnu.org; Mon, 07 Sep 2015 05:57:01 -0400 References: <1441612292-14845-1-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <55ED5F65.3060809@redhat.com> Date: Mon, 7 Sep 2015 11:56:53 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] add macro file for coccinelle List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , QEMU Developers , Markus Armbruster On 07/09/2015 11:22, Peter Maydell wrote: > On 7 September 2015 at 08:51, Paolo Bonzini wrote: >> Coccinelle chokes on some idioms from compiler.h and queue.h. >> Extract those in a macro file, to be used with "--macro-file >> scripts/cocci-macro-file.h". > > Can we put the "how to use this" instructions in the file > itself as well as in the commit message, please? Like this? /* Coccinelle only does limited parsing of headers, and chokes on some idioms * defined in compiler.h and queue.h. Macros that Coccinelle must know about * in order to parse .c files must be in a separate macro file---which is * exactly what you're staring at now. * * To use this file, add the "--macro-file scripts/cocci-macro-file.h" to the * Coccinelle command line. */ Paolo