From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: andrey@xdel.ru, qemu-stable@nongnu.org, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCH] block/iscsi: validate block size returned from target
Date: Mon, 7 Sep 2015 12:39:50 +0200 [thread overview]
Message-ID: <55ED6976.2010000@redhat.com> (raw)
In-Reply-To: <55E41297.5000303@kamp.de>
On 31/08/2015 10:38, Peter Lieven wrote:
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index 5002916..fac3a7a 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -1214,6 +1214,10 @@ static void iscsi_readcapacity_sync(IscsiLun
>> *iscsilun, Error **errp)
>> if (task == NULL || task->status != SCSI_STATUS_GOOD) {
>> error_setg(errp, "iSCSI: failed to send readcapacity10
>> command.");
>> + } else if (!iscsilun->block_size ||
>> + iscsilun->block_size % BDRV_SECTOR_SIZE) {
>> + error_setg(errp, "iSCSI: the target returned an invalid "
>> + "block size of %d.", iscsilun->block_size);
>> }
>> if (task) {
>> scsi_free_scsi_task(task);
>
> Ping
Queued but not sent due to KVM Forum and vacation.
Paolo
prev parent reply other threads:[~2015-09-07 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 11:33 [Qemu-devel] [PATCH] block/iscsi: validate block size returned from target Peter Lieven
2015-08-31 8:38 ` Peter Lieven
2015-09-07 10:39 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED6976.2010000@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrey@xdel.ru \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).