From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYtyW-0000Kc-6o for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:48:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYtyS-0005dr-RP for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:48:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYtyS-0005dg-M7 for qemu-devel@nongnu.org; Mon, 07 Sep 2015 06:48:32 -0400 References: <1440719744-24755-1-git-send-email-mdroth@linux.vnet.ibm.com> <1440719744-24755-4-git-send-email-mdroth@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <55ED6B7B.9060000@redhat.com> Date: Mon, 7 Sep 2015 12:48:27 +0200 MIME-Version: 1.0 In-Reply-To: <1440719744-24755-4-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, yhindin@redhat.com, leonid@daynix.com On 28/08/2015 01:55, Michael Roth wrote: > Now we can build qemu-ga MSI package with: > ./configure ... > make qemu-ga.exe > make msi > > or simply: > ./configure ... > make msi Shouldn't the latter have always worked? I think that if someone does "make qemu-ga.exe" they should *not* get the VSS files. Perhaps we can add a Win32-specific phony qemu-ga target to build both qemu-ga.exe and the VSS files, but this patch's use of filter-out is a bit ugly. Paolo