* [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change
@ 2015-08-27 9:06 Michael S. Tsirkin
2015-09-07 11:00 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-08-27 9:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Mike Day, Paolo Bonzini, Fam Zheng, qemu-stable
commit 9b8424d5735278ca382f11adc7c63072b632ab83
"exec: split length -> used_length/max_length"
changed field names in struct RAMBlock
It turns out that scripts/dump-guest-memory.py was
poking at this field, update it accordingly.
Cc: qemu-stable@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
scripts/dump-guest-memory.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
index dc8e44a..08796ff 100644
--- a/scripts/dump-guest-memory.py
+++ b/scripts/dump-guest-memory.py
@@ -118,7 +118,7 @@ shape and this command should mostly work."""
def qemu_get_ram_block(self, ram_addr):
ram_blocks = gdb.parse_and_eval("ram_list.blocks")
for block in self.qlist_foreach(ram_blocks, "next"):
- if (ram_addr - block["offset"] < block["length"]):
+ if (ram_addr - block["offset"] < block["used_length"]):
return block
raise gdb.GdbError("Bad ram offset %x" % ram_addr)
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change
2015-08-27 9:06 [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change Michael S. Tsirkin
@ 2015-09-07 11:00 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-09-07 11:00 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Mike Day, Fam Zheng, qemu-stable
On 27/08/2015 11:06, Michael S. Tsirkin wrote:
> commit 9b8424d5735278ca382f11adc7c63072b632ab83
> "exec: split length -> used_length/max_length"
> changed field names in struct RAMBlock
>
> It turns out that scripts/dump-guest-memory.py was
> poking at this field, update it accordingly.
>
> Cc: qemu-stable@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> scripts/dump-guest-memory.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
> index dc8e44a..08796ff 100644
> --- a/scripts/dump-guest-memory.py
> +++ b/scripts/dump-guest-memory.py
> @@ -118,7 +118,7 @@ shape and this command should mostly work."""
> def qemu_get_ram_block(self, ram_addr):
> ram_blocks = gdb.parse_and_eval("ram_list.blocks")
> for block in self.qlist_foreach(ram_blocks, "next"):
> - if (ram_addr - block["offset"] < block["length"]):
> + if (ram_addr - block["offset"] < block["used_length"]):
> return block
> raise gdb.GdbError("Bad ram offset %x" % ram_addr)
>
>
Thanks, queued for my next pull request.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27 9:06 [Qemu-devel] [PATCH] scripts/dump-guest-memory.py: fix after RAMBlock change Michael S. Tsirkin
2015-09-07 11:00 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).